Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] Changes function definition type to enum #211782

Merged
merged 9 commits into from
Feb 20, 2025
Merged

[ES|QL] Changes function definition type to enum #211782

merged 9 commits into from
Feb 20, 2025

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Feb 19, 2025 •
edited by kibanamachine
Loading

Summary

Closes #211775

Changes the definition type to enum

@stratoula stratoula changed the title Change function definition type Changes function definition type Feb 20, 2025
@stratoula stratoula changed the title Changes function definition type Changes function definition type to enum Feb 20, 2025
@stratoula stratoula added release_note:skip Skip the PR/issue when compiling release notes v9.1.0 v8.19.0 Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana backport:version Backport to applied version labels labels Feb 20, 2025
@stratoula stratoula changed the title Changes function definition type to enum [ES|QL] Changes function definition type to enum Feb 20, 2025
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #30 / dashboard app - esql controls dashboard - add a value type ES|QL control should update the Lens chart accordingly
  • [job] [logs] x-pack/test_serverless/functional/test_suites/observability/common_configs/config.group5.ts / discover/group4 adhoc data views should update id after data view field edit

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
esql 237.1KB 237.3KB +122.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/esql-validation-autocomplete 13 14 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.6MB 3.6MB +146.0B

History

@stratoula stratoula marked this pull request as ready for review February 20, 2025 11:17
@stratoula stratoula requested a review from a team as a code owner February 20, 2025 11:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

drewdaemon
drewdaemon approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good 🤷‍♂️

@stratoula stratoula merged commit 6b3fce9 into elastic:main Feb 20, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/13443193155

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 20, 2025
@stratoula
[ES|QL] Changes function definition type to enum (elastic#211782)
7f7a54f 
(cherry picked from commit 6b3fce9)
@kibanamachine kibanamachine mentioned this pull request Feb 20, 2025
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 20, 2025
@kibanamachine @stratoula
[8.x] [ES|QL] Changes function definition type to enum (#211782) (#21…
73c67d9 
…1965)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES|QL] Changes function definition type to enum
(#211782)](#211782)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2025-02-20T19:31:01Z","message":"[ES|QL]
Changes function definition type to enum
(#211782)","sha":"6b3fce90a05025e4d896eb42484449f46a8897c4","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL]
Changes function definition type to
enum","number":211782,"url":"https://github.com/elastic/kibana/pull/211782","mergeCommit":{"message":"[ES|QL]
Changes function definition type to enum
(#211782)","sha":"6b3fce90a05025e4d896eb42484449f46a8897c4"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211782","number":211782,"mergeCommit":{"message":"[ES|QL]
Changes function definition type to enum
(#211782)","sha":"6b3fce90a05025e4d896eb42484449f46a8897c4"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewdaemon drewdaemon drewdaemon approved these changes

Assignees
No one assigned
Labels
backport:version Backport to applied version labels Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana v8.19.0 v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ES|QL] Change fieldDefinitionType to enum
4 participants
@stratoula @elasticmachine @kibanamachine @drewdaemon