[Fleet] Do not allow alpha, beta, rc suffixes in agent versions #211787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaElastic
added
release_note:skip
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
|
/ci |
kpollich
requested changes
Feb 19, 2025
There was a problem hiding this comment.
I think we want to exclude beta/rc versions from this list in serverless. Right now, we're showing 9.0.0 in serverless because we see 9.0.1-beta-1 as available based on the product versions API, and then it's coerced to 9.0.0. At least for serverless production we should not be showing prerelease versions of agent (except for versions that end in +build 🙃) at all.
nchaulet
changed the title
|
Starting backport for target branches: 9.0 |
💚 Build Succeeded
Metrics [docs]
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 19, 2025
) ## Summary Closes elastic#211777 Add agent flyout should show `9.0.0-beta1` now: <img width="2540" alt="image" src="https://github.com/user-attachments/assets/86259eea-5858-4d06-8989-8fadb3a57f96" /> When `9.0.0` comes out, that should show up as latest. For example, `8.0.0` versions come back in this order: <img width="462" alt="image" src="https://github.com/user-attachments/assets/c5204806-3cf7-4c65-bb60-21d176f24f17" /> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit ba2caf9)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 19, 2025
…) (#211849) # Backport This will backport the following commits from `main` to `9.0`: - [[Fleet] allow alpha, beta, rc suffixes in agent versions (#211787)](#211787) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Julia Bardi","email":"90178898+juliaElastic@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-19T20:37:28Z","message":"[Fleet] allow alpha, beta, rc suffixes in agent versions (#211787)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/211777\n\nAdd agent flyout should show `9.0.0-beta1` now:\n<img width=\"2540\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/86259eea-5858-4d06-8989-8fadb3a57f96\"\n/>\n\nWhen `9.0.0` comes out, that should show up as latest. For example,\n`8.0.0` versions come back in this order:\n<img width=\"462\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/c5204806-3cf7-4c65-bb60-21d176f24f17\"\n/>\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"ba2caf92c6e70d94d9743ff7628400750cb35d51","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","backport:prev-minor","v9.1.0"],"title":"[Fleet] Do not allow alpha, beta, rc suffixes in agent versions","number":211787,"url":"https://github.com/elastic/kibana/pull/211787","mergeCommit":{"message":"[Fleet] allow alpha, beta, rc suffixes in agent versions (#211787)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/211777\n\nAdd agent flyout should show `9.0.0-beta1` now:\n<img width=\"2540\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/86259eea-5858-4d06-8989-8fadb3a57f96\"\n/>\n\nWhen `9.0.0` comes out, that should show up as latest. For example,\n`8.0.0` versions come back in this order:\n<img width=\"462\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/c5204806-3cf7-4c65-bb60-21d176f24f17\"\n/>\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"ba2caf92c6e70d94d9743ff7628400750cb35d51"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211787","number":211787,"mergeCommit":{"message":"[Fleet] allow alpha, beta, rc suffixes in agent versions (#211787)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/211777\n\nAdd agent flyout should show `9.0.0-beta1` now:\n<img width=\"2540\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/86259eea-5858-4d06-8989-8fadb3a57f96\"\n/>\n\nWhen `9.0.0` comes out, that should show up as latest. For example,\n`8.0.0` versions come back in this order:\n<img width=\"462\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/c5204806-3cf7-4c65-bb60-21d176f24f17\"\n/>\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"ba2caf92c6e70d94d9743ff7628400750cb35d51"}}]}] BACKPORT--> Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #211777
Add agent flyout should not show
9.0.0or9.0.0-beta1now as currently only 9.0.0-rc1 is available:Checklist