[Obs AI Assistant] Share conversations #211854

viduni94 · 2025-02-19T22:36:05Z

Closes #206590
Closes #211710
Closes #211604
Closes https://github.com/elastic/obs-ai-assistant-team/issues/215

Summary

This PR implements conversation sharing for Obs AI Assistant conversations.

The features included are as follows:

Refactored ChatActionsMenu - Removed Copy Conversation and Duplicate options
Removed the banner added in [Obs AI Assistant] Duplicate conversations #209382
Removed the conversation input box (PromptEditor), if the user who is viewing the conversation cannot continue it.
Implemented a ChatBanner - This will show whether a conversation is shared with the team (The banner content differs based on who is viewing the conversation)
Implemented ChatContextMenu for conversation specific actions. This includes "Duplicate", "Copy conversation", "Copy URL" and "Delete". "Delete" functionality is only available to the conversation owner. (This menu is only included in the ChatHeader at the moment because Eui doesn't support passing a node to EuiListGroupItem to include this in the ConversationList. This will be refactored in [Obs AI Assistant] Archiving conversations #209386)
Implemented useConversationContextMenu for "copy" and "delete" functionalities.
Implemented ChatSharingMenu to mark a conversation as shared/private. This is only enabled for the owner of the conversation. For other users, a disabled badge will be shown stating whether the conversation is Private or Shared.
Implemented updateConversationAccess route.
Updated the Chat Item Actions Inspect Prompt Button to Inspect. This was eye before.
Implemented a custom component ConversationListItemLabel to show the shared icon in ConversationList.
Re-named "Copy conversation" to "Copy to clipboard" to avoid ambiguity with "Duplicate".
Added success toast on "Copy to clipboard"

Note: If a conversation started from contextual insights, and then the user continue the conversation --> The conversation will be stored. However, if the user deletes the continued conversation, they will be reverted to the initial messages from the contextual insights.

Screen recording

sharing-conversations.mov

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

…nd other updates) (elastic#206590)

…#206590)

…ssion handling (elastic#206590)

)

github-actions · 2025-03-05T18:46:09Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

kibanamachine · 2025-03-05T19:50:42Z

Project deployed, see credentials at: https://buildkite.com/elastic/kibana-deploy-project-from-pr/builds/354

viduni94 · 2025-03-05T23:50:14Z

x-pack/test/observability_ai_assistant_functional/tests/conversations/index.spec.ts

@@ -408,7 +379,6 @@ export default function ApiTest({ getService, getPageObjects }: FtrProviderConte
                    'And what are SLIs?'
                  );
                  await testSubjects.pressEnter(ui.pages.conversations.chatInput);
-                  log.info('SQREN: Waiting for the message to be displayed');


@sorenlouv Let me know if these were left intentionally.. I can add it back

elasticmachine · 2025-03-05T23:50:38Z

Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant)

elasticmachine · 2025-03-06T00:52:36Z

💔 Build Failed

Buildkite Build
Commit: 69a0870
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-211854-69a0870d65a2

Failed CI Steps

Test Failures

[job] [logs] Jest Tests #4 / ConversationList calls delete conversation when delete icon is clicked
[job] [logs] Jest Tests #4 / ConversationList calls delete conversation when delete icon is clicked
[job] [logs] Jest Tests #4 / ConversationList calls onConversationSelect when a conversation is clicked
[job] [logs] Jest Tests #4 / ConversationList calls onConversationSelect when a conversation is clicked
[job] [logs] Jest Tests #4 / ConversationList displays error state
[job] [logs] Jest Tests #4 / ConversationList displays error state
[job] [logs] Jest Tests #4 / ConversationList displays loading state
[job] [logs] Jest Tests #4 / ConversationList displays loading state
[job] [logs] Jest Tests #4 / ConversationList renders "no conversations" message when there are no conversations
[job] [logs] Jest Tests #4 / ConversationList renders "no conversations" message when there are no conversations
[job] [logs] Jest Tests #4 / ConversationList renders a new chat button and triggers onConversationSelect when clicked
[job] [logs] Jest Tests #4 / ConversationList renders a new chat button and triggers onConversationSelect when clicked
[job] [logs] Jest Tests #4 / ConversationList renders categorized conversations
[job] [logs] Jest Tests #4 / ConversationList renders categorized conversations
[job] [logs] Jest Tests #4 / ConversationList renders the component without errors
[job] [logs] Jest Tests #4 / ConversationList renders the component without errors

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`observabilityAIAssistantApp`	428	434	+6
`observabilityAiAssistantManagement`	376	382	+6
`searchAssistant`	257	263	+6
total			+18

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/ai-assistant`	78	102	+24
`observabilityAIAssistant`	385	391	+6
total			+30

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`observabilityAIAssistantApp`	255.1KB	264.2KB	+9.1KB
`searchAssistant`	149.7KB	158.2KB	+8.6KB
total			+17.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`observabilityAIAssistant`	38.0KB	38.1KB	+115.0B
`searchAssistant`	5.4KB	5.4KB	-3.0B
total			+112.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/ai-assistant`	78	102	+24
`observabilityAIAssistant`	387	393	+6
total			+30

History

💔 Build #281225 failed e491e70

cc @viduni94

viduni94 · 2025-03-06T03:28:48Z

...tion/deployment_agnostic/apis/observability/ai_assistant/conversations/conversations.spec.ts

@@ -625,5 +625,156 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon
        });
      });
    });
+
+    describe('conversation sharing', () => {


I've verified these in stateful and serverless local. Will be testing on MKI tomorrow.

arturoliduena · 2025-03-06T07:26:40Z

x-pack/platform/packages/shared/kbn-ai-assistant/src/chat/chat_body.tsx

@@ -351,6 +346,65 @@ export function ChatBody({
    }
  };

+  const handleConversationAccessUpdate = async (access: ConversationAccess) => {
+    await updateConversationAccess(access);
+    conversation.refresh();


Do we need an additional call to refresh the conversation after changing access?
The UI is already updated, but should we refresh the conversation if there’s an error when calling updateConversationAccess(access)

arturoliduena · 2025-03-06T07:42:25Z

x-pack/platform/packages/shared/kbn-ai-assistant/src/chat/chat_body.tsx

+        />
+      );
+    }
+  } else {


These two cases are functionally identical:

"Public, conversation has a user, but current user is not the owner. Don't show prompt editor, only show the banner with Duplicate button"

"Public, but conversation doesn't have a user (for backwards compatibility with old conversations generated by the rule connector). Don't show prompt editor, only show the banner with Duplicate button"

Since isConversationOwnedByCurrentUser already checks if the conversation has no user (returning false in both cases), the UI behavior remains the same (showPromptEditor and sharedBanner).
You can delete one of them, avoiding duplicated code.

arturoliduena · 2025-03-06T08:12:37Z

x-pack/platform/plugins/shared/observability_ai_assistant/server/routes/conversations/route.ts

@@ -216,12 +216,46 @@ const deleteConversationRoute = createObservabilityAIAssistantServerRoute({
  },
 });

+const updateConversationAccessRoute = createObservabilityAIAssistantServerRoute({


I don’t think we should add a separate router for each conversation property update. We already have an update router that we can use, and we can also remove the dedicated update Title router.

We have two possible approaches:

Only keep PUT conversation router. Use PUT to update the entire conversation. The request must contain the full updated conversation document.

Remove title and access routers, keep PUT conversation, add PATCH conversation. Use PATCH to update specific fields, The request includes only the properties being modified (e.g., title and access).

what do you think?

arturoliduena · 2025-03-06T08:14:37Z

x-pack/platform/plugins/shared/observability_ai_assistant/server/service/client/index.ts

+    access: ConversationAccess;
+  }) => {
+    if (![ConversationAccess.SHARED, ConversationAccess.PRIVATE].includes(access)) {
+      throw badRequest('Invalid access value. Allowed values are SHARED and PRIVATE.');


This validation/error seems more appropriate at the router level rather than in the client method.

arturoliduena · 2025-03-06T08:19:58Z

x-pack/platform/plugins/shared/observability_ai_assistant/server/service/client/index.ts

+    }
+
+    const conversation = await this.get(conversationId);
+    if (!conversation) {


You can use either getConversationWithMetaFields or get, as both methods query the document. The get method internally calls getConversationWithMetaFields and also validates if the document exists.

dgieselaar · 2025-03-06T08:28:04Z

x-pack/platform/plugins/shared/observability_ai_assistant/server/routes/conversations/route.ts

+      conversationId: t.string,
+    }),
+    body: t.type({
+      access: t.string,


enum? (t.literal)

dgieselaar · 2025-03-06T08:28:16Z

x-pack/platform/plugins/shared/observability_ai_assistant/server/routes/conversations/route.ts

+      access: params.body.access as ConversationAccess,
+    });
+
+    return Promise.resolve(conversation);


why do we need Promise.resolve here?

dgieselaar · 2025-03-06T08:29:49Z

x-pack/platform/plugins/shared/observability_ai_assistant/server/service/client/index.ts

@@ -140,7 +141,7 @@ export class ObservabilityAIAssistantClient {
      return false;
    }

-    return conversation.user.id
+    return conversation.user.id && user.id


In what case is user.id not set, but does the current user still have access to the conversation?

dgieselaar · 2025-03-06T08:31:45Z

x-pack/platform/plugins/shared/observability_ai_assistant/server/service/client/index.ts

+    const updatedConversation: Conversation = merge({}, conversation, {
+      public: isPublic,
+      conversation: {
+        last_updated: new Date().toISOString(),
+      },
+    });
+
+    await this.dependencies.esClient.asInternalUser.update({
+      id: document._id!,
+      index: document._index,
+      doc: updatedConversation,
+      refresh: true,
+    });


can we use the .update function on the AI Assistant client instead?

viduni94 added release_note:feature Makes this part of the condensed release notes Team:Obs AI Assistant Observability AI Assistant backport:version Backport to applied version labels v9.1.0 v8.19.0 labels Feb 19, 2025

viduni94 self-assigned this Feb 19, 2025

viduni94 changed the title ~~[Obs AI Assistant] Sharing conversations~~ [Obs AI Assistant] Share conversations Feb 19, 2025

viduni94 force-pushed the sharing-conversations branch 5 times, most recently from 5e7a5ff to b487cf0 Compare February 26, 2025 14:23

viduni94 added 11 commits February 27, 2025 11:30

[Obs AI Assistant] Sharing conversations (new context menu for chat a…

438c37a

…nd other updates) (elastic#206590)

[Obs AI Assistant] Add chat context menu and copy URL functionality

84653a8

[Obs AI Assistant] Add custom list item to conversation list (elastic…

f58bca9

…#206590)

[Obs AI Assistant] Update context menu and other styles (elastic#206590)

bea40b3

[Obs AI Assistant] Update delete option (elastic#206590)

6ca37fc

[Obs AI Assistant] Refactor context menu (elastic#206590)

97120dc

[Obs AI Assistant] Refactor context menu

87bbf79

[Obs AI Assistant] Update eye icon to inspect icon (elastic#206590)

42897d7

[Obs AI Assistant] Conversation sharing route and other related permi…

8439656

…ssion handling (elastic#206590)

[Obs AI Assistant] Update share badge for readonly users (elastic#206590

04c42f4

)

[Obs AI Assistant] Add tests for components and hooks (elastic#206590)

e6bdd08

viduni94 force-pushed the sharing-conversations branch from f467bed to e6bdd08 Compare February 27, 2025 16:30

viduni94 added 6 commits February 28, 2025 13:26

Merge branch 'main' into sharing-conversations

5fb23ac

Merge branch 'main' into sharing-conversations

3aa14cb

Merge branch 'main' into sharing-conversations

8f53ebb

Resolved merge conflicts

6c38bca

Move duplicate conversation to context menu (elastic#206590)

66da25f

Restrict deletions to owners (elastic#206590)

74ab61e

Add API tests (elastic#206590)

3c5d32f

viduni94 added the ci:project-deploy-observability Create an Observability project label Mar 5, 2025

Merge branch 'main' into sharing-conversations

e491e70

kibanamachine and others added 2 commits March 5, 2025 19:16

[CI] Auto-commit changed files from 'node scripts/notice'

dca2fd0

[Obs AI Assistant] Fix i18n and props in tests

77b4973

Add functional tests (elastic#206590)

fc91c5f

viduni94 commented Mar 5, 2025

View reviewed changes

viduni94 marked this pull request as ready for review March 5, 2025 23:50

viduni94 requested review from a team as code owners March 5, 2025 23:50

Merge branch 'main' into sharing-conversations

69a0870

viduni94 commented Mar 6, 2025

View reviewed changes

arturoliduena reviewed Mar 6, 2025

View reviewed changes

dgieselaar reviewed Mar 6, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Obs AI Assistant] Share conversations #211854

[Obs AI Assistant] Share conversations #211854

viduni94 commented Feb 19, 2025 •

edited

Loading

github-actions bot commented Mar 5, 2025

kibanamachine commented Mar 5, 2025

viduni94 Mar 5, 2025

elasticmachine commented Mar 5, 2025

elasticmachine commented Mar 6, 2025 •

edited

Loading

API count

viduni94 Mar 6, 2025

arturoliduena Mar 6, 2025

arturoliduena Mar 6, 2025

arturoliduena Mar 6, 2025

arturoliduena Mar 6, 2025

arturoliduena Mar 6, 2025

dgieselaar Mar 6, 2025

dgieselaar Mar 6, 2025

dgieselaar Mar 6, 2025

dgieselaar Mar 6, 2025

[Obs AI Assistant] Share conversations #211854

Are you sure you want to change the base?

[Obs AI Assistant] Share conversations #211854

Conversation

viduni94 commented Feb 19, 2025 • edited Loading

Summary

Screen recording

Checklist

github-actions bot commented Mar 5, 2025

🤖 GitHub comments

kibanamachine commented Mar 5, 2025

Choose a reason for hiding this comment

elasticmachine commented Mar 5, 2025

elasticmachine commented Mar 6, 2025 • edited Loading

💔 Build Failed

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

History

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

viduni94 commented Feb 19, 2025 •

edited

Loading

elasticmachine commented Mar 6, 2025 •

edited

Loading