[Security Solution] Add UI incentivizers to upgrade prebuilt rules #211862
+2,051
−1,062
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import { EuiCallOut, EuiSpacer, EuiLink } from '@elastic/eui'; | ||
| import React, { useMemo } from 'react'; | ||
| import type { RuleResponse } from '../../../../../common/api/detection_engine'; | ||
| import * as i18n from './translations'; | ||
| import { usePrebuiltRulesUpgrade } from '../../hooks/use_prebuilt_rules_upgrade'; | ||
|
|
||
| interface RuleUpdateCalloutProps { | ||
| rule: RuleResponse; | ||
| message: string; | ||
| actionButton?: JSX.Element; | ||
| onUpgrade?: () => void; | ||
| } | ||
|
|
||
| const RuleUpdateCalloutComponent = ({ | ||
| rule, | ||
| message, | ||
| actionButton, | ||
| onUpgrade, | ||
| }: RuleUpdateCalloutProps): JSX.Element | null => { | ||
| const { upgradeReviewResponse, rulePreviewFlyout, openRulePreview } = usePrebuiltRulesUpgrade({ | ||
| pagination: { | ||
| page: 1, // we only want to fetch one result | ||
| perPage: 1, | ||
| }, | ||
| filter: { rule_ids: [rule.id] }, | ||
| onUpgrade, | ||
| }); | ||
|
|
||
| const isRuleUpgradeable = useMemo( | ||
| () => upgradeReviewResponse !== undefined && upgradeReviewResponse.total > 0, | ||
| [upgradeReviewResponse] | ||
| ); | ||
|
|
||
| const updateCallToActionButton = useMemo(() => { | ||
| if (actionButton) { | ||
| return actionButton; | ||
| } | ||
| return ( | ||
| <EuiLink | ||
| onClick={() => openRulePreview(rule.rule_id)} | ||
| data-test-subj="ruleDetailsUpdateRuleCalloutButton" | ||
| > | ||
| {i18n.HAS_RULE_UPDATE_CALLOUT_BUTTON} | ||
| </EuiLink> | ||
| ); | ||
| }, [actionButton, openRulePreview, rule.rule_id]); | ||
|
|
||
| if (!isRuleUpgradeable) { | ||
| return null; | ||
| } | ||
|
|
||
| return ( | ||
| <> | ||
| <EuiCallOut title={i18n.HAS_RULE_UPDATE_CALLOUT_TITLE} color="primary" iconType="gear"> | ||
|
There was a problem hiding this comment. Mixing
|
||
| <p>{message}</p> | ||
| {updateCallToActionButton} | ||
| </EuiCallOut> | ||
| <EuiSpacer size="l" /> | ||
| {rulePreviewFlyout} | ||
| </> | ||
| ); | ||
| }; | ||
|
|
||
| export const RuleUpdateCallout = React.memo(RuleUpdateCalloutComponent); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import React from 'react'; | ||
| import { EuiCallOut } from '@elastic/eui'; | ||
| import * as i18n from './translations'; | ||
|
|
||
| export const RuleHasMissingBaseVersionCallout = () => ( | ||
| <EuiCallOut color="warning" size="s"> | ||
| <p>{i18n.RULE_BASE_VERSION_IS_MISSING_DESCRIPTION}</p> | ||
| </EuiCallOut> | ||
| ); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment. Let's roll back changes in this files. It looks like only fragment wrappers left here. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We mostly stick to
upgradeword in the codebase while usingupdatein texts exposed to users. I recommend to stick toupgradein names you used for consistency.