Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upgrade assistant] Filter Kibana deprecations issues by status #211900

Conversation

SoniaSanzV
Copy link
Contributor

@SoniaSanzV SoniaSanzV commented Feb 20, 2025

Part of #208262

Summary

On the Kibana list of deprecations in Upgrade Assistant, replace the Critical button filter with a Dropdown allowing to select between Critical and Warning. Similar to what was done for Elasticsearch deprecations #211581

Screenshot 2025-02-20 at 13 45 03

Ask me for a data folder with some Kibana deprecations (I manage to have warnings but not Critical, though).

@SoniaSanzV SoniaSanzV added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:Upgrade Assistant backport:version Backport to applied version labels v8.18.0 v8.19.0 labels Feb 20, 2025
@SoniaSanzV SoniaSanzV requested a review from a team February 20, 2025 12:48
@SoniaSanzV SoniaSanzV self-assigned this Feb 20, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@mattkime
Copy link
Contributor

@SoniaSanzV I think we want this in main and then backported a bunch to include 8.19 and 8.18 among others - otherwise we won't get the benefit of this when it comes time to upgrade from 9 to 10.

@sabarasaba
Copy link
Member

@SoniaSanzV I think we want this in main and then backported a bunch to include 8.19 and 8.18 among others - otherwise we won't get the benefit of this when it comes time to upgrade from 9 to 10.

it's hard to work directly on main because we cant show any of the deprecations that we need for testing. Because of this we've been working directly on 8.x and we created another issue to track which commits we are putting in 8.x that will later need to be forwardported into main. We can then cherry-pick these commits on a weekly/bi-weekly basis and create a PR to move those into main too.

Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm, thanks for patching this up! 🚀

@SoniaSanzV SoniaSanzV enabled auto-merge (squash) February 21, 2025 09:02
@SoniaSanzV SoniaSanzV merged commit 3cb68cd into elastic:8.x Feb 21, 2025
8 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
upgradeAssistant 207.2KB 207.6KB +362.0B

History

cc @SoniaSanzV

@SoniaSanzV SoniaSanzV deleted the upgrade_assistant/filter_kibana_deprecations_by_status branch February 21, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels Feature:Upgrade Assistant release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.18.0 v8.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants