Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Synthetics] modify use overview status hook to mimic use_monitor_list (#210936) #211931

Merged
merged 1 commit into from
Feb 20, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@
* 2.0.
*/

import { useEffect } from 'react';
import { useEffect, useRef } from 'react';
import { useDispatch, useSelector } from 'react-redux';
import useDebounce from 'react-use/lib/useDebounce';
import { useSyntheticsRefreshContext } from '../../../contexts/synthetics_refresh_context';
import { selectOverviewPageState } from '../../../state';
import {
Expand All @@ -17,22 +18,51 @@ import {

export function useOverviewStatus({ scopeStatusByLocation }: { scopeStatusByLocation: boolean }) {
const pageState = useSelector(selectOverviewPageState);

const { status, error, loaded, loading, allConfigs } = useSelector(selectOverviewStatus);
const isInitialMount = useRef(true);

const { lastRefresh } = useSyntheticsRefreshContext();

const dispatch = useDispatch();

// Periodically refresh
useEffect(() => {
if (loaded) {
if (!isInitialMount.current) {
dispatch(quietFetchOverviewStatusAction.get({ pageState, scopeStatusByLocation }));
} else {
dispatch(fetchOverviewStatusAction.get({ pageState, scopeStatusByLocation }));
}
// loaded is omitted from the dependency array because it is not used in the callback
// specifically only want to run this on refreshInterval change
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [dispatch, lastRefresh, pageState, scopeStatusByLocation]);
}, [lastRefresh]);

// On initial mount, load the page
useDebounce(
() => {
if (isInitialMount.current) {
if (loaded) {
dispatch(quietFetchOverviewStatusAction.get({ pageState, scopeStatusByLocation }));
} else {
dispatch(fetchOverviewStatusAction.get({ pageState, scopeStatusByLocation }));
}
}
},
100,
// we don't use pageState or scopeStatus here, for pageState, useDebounce will handle it
[dispatch]
);

useDebounce(
() => {
// Don't load on initial mount, only meant to handle pageState changes
if (isInitialMount.current || !loaded) {
// setting false here to account for debounce timing
isInitialMount.current = false;
return;
}
dispatch(fetchOverviewStatusAction.get({ pageState, scopeStatusByLocation }));
},
100,
[pageState, scopeStatusByLocation]
);

return {
status,
Expand Down