[embeddable] remove EmbeddableInput type #211949
Merged
+116
−220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
|
/ci |
|
/ci |
|
/ci |
|
/ci |
|
/ci |
nreese
added
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
ThomThomson
approved these changes
Mar 4, 2025
| newPanels.push( | ||
| convertPanelStateToSavedDashboardPanel(panel.panelIndex, { | ||
| ...originalPanelState, | ||
| explicitInput: { | ||
| ...originalPanelState.explicitInput, | ||
| ...(originalPanelState.explicitInput.title === '' && | ||
| !originalPanelState.explicitInput.hidePanelTitles | ||
| ...((originalPanelState.explicitInput as { title?: string }).title === '' && |
There was a problem hiding this comment.
I wonder if we can use one of the type guards like stateHasTitles from src/platform/packages/shared/presentation/presentation_publishing/interfaces/titles/title_manager.ts instead of just casting with as here?
There was a problem hiding this comment.
presentation_publishing is shared-browser plugin. Is it worth making this shared-common plugin so it can be used in server?
There was a problem hiding this comment.
Ah I see, likely not worth the change without further discussion
botelastic
bot
added
Feature:Embedding
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
|
dej611
approved these changes
Mar 5, 2025
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 6, 2025
EmbeddableInput type is part of the legacy embeddable system. The legacy embeddable system is being removed and as such, the EmbeddableInput type is being removed. --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 04ee5fc)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 6, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [[embeddable] remove EmbeddableInput type (#211949)](#211949) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2025-03-06T01:41:00Z","message":"[embeddable] remove EmbeddableInput type (#211949)\n\nEmbeddableInput type is part of the legacy embeddable system. The legacy\nembeddable system is being removed and as such, the EmbeddableInput type\nis being removed.\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"04ee5fc4f355dedba3d5c7e2183417c04a6dc5c0","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Embedding","Team:Presentation","release_note:skip","Team:obs-ux-infra_services","project:embeddableRebuild","backport:version","v9.1.0","v8.19.0"],"title":"[embeddable] remove EmbeddableInput type","number":211949,"url":"https://github.com/elastic/kibana/pull/211949","mergeCommit":{"message":"[embeddable] remove EmbeddableInput type (#211949)\n\nEmbeddableInput type is part of the legacy embeddable system. The legacy\nembeddable system is being removed and as such, the EmbeddableInput type\nis being removed.\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"04ee5fc4f355dedba3d5c7e2183417c04a6dc5c0"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211949","number":211949,"mergeCommit":{"message":"[embeddable] remove EmbeddableInput type (#211949)\n\nEmbeddableInput type is part of the legacy embeddable system. The legacy\nembeddable system is being removed and as such, the EmbeddableInput type\nis being removed.\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"04ee5fc4f355dedba3d5c7e2183417c04a6dc5c0"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EmbeddableInput type is part of the legacy embeddable system. The legacy embeddable system is being removed and as such, the EmbeddableInput type is being removed.