Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[discover] lazy load actions #211974

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Feb 20, 2025

No description provided.

@elasticmachine
Copy link
Contributor

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!
  • Click to trigger kibana-deploy-cloud-from-pr for this PR!

@@ -7,11 +7,4 @@
* License v3.0 only", or the "Server Side Public License, v 1".
*/

/*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved loadSharingDataHelpers to public/index.ts to avoid loading getSortForEmbeddable in page load bundle.

@nreese
Copy link
Contributor Author

nreese commented Feb 20, 2025

/ci

@nreese
Copy link
Contributor Author

nreese commented Feb 20, 2025

/ci

@nreese
Copy link
Contributor Author

nreese commented Feb 20, 2025

/ci

@nreese
Copy link
Contributor Author

nreese commented Mar 5, 2025

/ci

@nreese
Copy link
Contributor Author

nreese commented Mar 6, 2025

/ci

@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 6, 2025

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #5 / discover/context_awareness extension getAdditionalCellActions data view mode should render additional cell actions for logs data source
  • [job] [logs] FTR Configs #27 / lens app - group 5 lens drag and drop tests keyboard drag and drop should reorder elements with keyboard
  • [job] [logs] FTR Configs #27 / lens app - group 5 lens drag and drop tests keyboard drag and drop should reorder elements with keyboard
  • [job] [logs] FTR Configs #74 / Monitoring app Elasticsearch nodes listing with offline node skipCloud should have a nodes table with correct rows with default sorting

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
discoverEnhanced 33 23 -10

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 917.8KB 920.9KB +3.1KB
discoverEnhanced 0.0B 4.7KB +4.7KB
total +7.8KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
discoverEnhanced 2 0 -2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
discover 44.2KB 41.0KB -3.2KB
discoverEnhanced 7.5KB 5.1KB -2.4KB
total -5.6KB
Unknown metric groups

API count

id before after diff
discoverEnhanced 35 23 -12

async chunk count

id before after diff
discoverEnhanced 0 1 +1

References to deprecated APIs

id before after diff
discover 11 10 -1
discoverEnhanced 2 0 -2
total -3

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants