Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Synthetics] introduce new spaces field for synthetics api keys (#211816) #212149

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…tic#211816)

### Summary

- Resolves elastic#211049
- Adds the ability for a user to create an API Key in synthetics
settings that applies to specified space(s)
- Reuses existing spaces combo box from private locations, enhances the
component to incorporate a generic interface and help text prop to
enable additional uses
- Modifies functionality of Generate API Key button to consider a blank
spaces field before creating the key
- Currently, in private locations, if the spaces field is blank, the
save button has no functionality, so this was copied here.

![Screenshot 2025-02-19 at 3 59
24 PM](https://github.com/user-attachments/assets/4bd7cf33-636a-4bba-a7fd-97b2315fcff1)

![Screenshot 2025-02-19 at 4 00
44 PM](https://github.com/user-attachments/assets/21b7cab6-8f95-44e9-b91d-f06e15cbac0c)

### Release Notes
Adds the ability for a user to create an API Key in synthetics settings
that applies only to specified space(s)

---------

Co-authored-by: Shahzad <shahzad31comp@gmail.com>
(cherry picked from commit de7d33d)
@kibanamachine kibanamachine enabled auto-merge (squash) February 21, 2025 19:32
@botelastic botelastic bot added the Team:obs-ux-management Observability Management User Experience Team label Feb 21, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@kibanamachine kibanamachine merged commit a4a46f2 into elastic:8.x Feb 21, 2025
13 checks passed
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Mar 4, 2025
…elastic#211816) (elastic#212149)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Synthetics] introduce new spaces field for synthetics api keys
(elastic#211816)](elastic#211816)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Bailey
Cash","email":"bailey.cash@elastic.co"},"sourceCommit":{"committedDate":"2025-02-21T19:25:54Z","message":"[Synthetics]
introduce new spaces field for synthetics api keys (elastic#211816)\n\n###
Summary\n\n- Resolves elastic#211049\n- Adds the ability for a user to create
an API Key in synthetics\nsettings that applies to specified space(s)\n-
Reuses existing spaces combo box from private locations, enhances
the\ncomponent to incorporate a generic interface and help text prop
to\nenable additional uses\n- Modifies functionality of Generate API Key
button to consider a blank\nspaces field before creating the key\n-
Currently, in private locations, if the spaces field is blank, the\nsave
button has no functionality, so this was copied here.\n\n![Screenshot
2025-02-19 at 3
59\n24 PM](https://github.com/user-attachments/assets/4bd7cf33-636a-4bba-a7fd-97b2315fcff1)\n\n![Screenshot
2025-02-19 at 4
00\n44 PM](https://github.com/user-attachments/assets/21b7cab6-8f95-44e9-b91d-f06e15cbac0c)\n\n###
Release Notes\nAdds the ability for a user to create an API Key in
synthetics settings\nthat applies only to specified
space(s)\n\n---------\n\nCo-authored-by: Shahzad
<shahzad31comp@gmail.com>","sha":"de7d33dec296a491ae9abd9f3b74859c0c8e78c7","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","v9.0.0","backport:prev-minor","Team:obs-ux-management","v9.1.0","v8.19.0"],"title":"[Synthetics]
introduce new spaces field for synthetics api
keys","number":211816,"url":"https://github.com/elastic/kibana/pull/211816","mergeCommit":{"message":"[Synthetics]
introduce new spaces field for synthetics api keys (elastic#211816)\n\n###
Summary\n\n- Resolves elastic#211049\n- Adds the ability for a user to create
an API Key in synthetics\nsettings that applies to specified space(s)\n-
Reuses existing spaces combo box from private locations, enhances
the\ncomponent to incorporate a generic interface and help text prop
to\nenable additional uses\n- Modifies functionality of Generate API Key
button to consider a blank\nspaces field before creating the key\n-
Currently, in private locations, if the spaces field is blank, the\nsave
button has no functionality, so this was copied here.\n\n![Screenshot
2025-02-19 at 3
59\n24 PM](https://github.com/user-attachments/assets/4bd7cf33-636a-4bba-a7fd-97b2315fcff1)\n\n![Screenshot
2025-02-19 at 4
00\n44 PM](https://github.com/user-attachments/assets/21b7cab6-8f95-44e9-b91d-f06e15cbac0c)\n\n###
Release Notes\nAdds the ability for a user to create an API Key in
synthetics settings\nthat applies only to specified
space(s)\n\n---------\n\nCo-authored-by: Shahzad
<shahzad31comp@gmail.com>","sha":"de7d33dec296a491ae9abd9f3b74859c0c8e78c7"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211816","number":211816,"mergeCommit":{"message":"[Synthetics]
introduce new spaces field for synthetics api keys (elastic#211816)\n\n###
Summary\n\n- Resolves elastic#211049\n- Adds the ability for a user to create
an API Key in synthetics\nsettings that applies to specified space(s)\n-
Reuses existing spaces combo box from private locations, enhances
the\ncomponent to incorporate a generic interface and help text prop
to\nenable additional uses\n- Modifies functionality of Generate API Key
button to consider a blank\nspaces field before creating the key\n-
Currently, in private locations, if the spaces field is blank, the\nsave
button has no functionality, so this was copied here.\n\n![Screenshot
2025-02-19 at 3
59\n24 PM](https://github.com/user-attachments/assets/4bd7cf33-636a-4bba-a7fd-97b2315fcff1)\n\n![Screenshot
2025-02-19 at 4
00\n44 PM](https://github.com/user-attachments/assets/21b7cab6-8f95-44e9-b91d-f06e15cbac0c)\n\n###
Release Notes\nAdds the ability for a user to create an API Key in
synthetics settings\nthat applies only to specified
space(s)\n\n---------\n\nCo-authored-by: Shahzad
<shahzad31comp@gmail.com>","sha":"de7d33dec296a491ae9abd9f3b74859c0c8e78c7"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Bailey Cash <bailey.cash@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants