[Fleet] Improve validation for dynamic Kafka topics

[Supplementing]

Closes #206194

Summary

Screen.Recording.2025-02-26.at.7.30.18.AM.mov

• Removed hardcoded wrapping of user-entered topics with %{[]} to fix issues arising from the user pre-wrapping, and also allow greater flexibility in naming
• Added validation rules to check for unclosed brackets & brackets with missing % preceding
• Added the auto-wrapping to the value field of items chosen from the dropdown to ensure they were always wrapped as intended
• Added test coverage for validating dynamic topics

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
• This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
• Flaky Test Runner was used on any tests changed
• The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

n/a

[elasticmachine]

Pinging @elastic/fleet (Team:Fleet)

[Supplementing]

@elasticmachine merge upstream

[kpollich]

Looking at the dropdown I wonder if we can change the "not recommended" text. I don't think we need to explicitly discourage the dynamic topic syntax like that.

[Supplementing]

Looking at the dropdown I wonder if we can change the "not recommended" text. I don't think we need to explicitly discourage the dynamic topic syntax like that.

I agree, it does make it feel like you're 'doing something wrong', when its really just a more 'advanced option' than inherently wrong, or to be discouraged.

[Supplementing]

@kpollich Also, do you think its worth maybe linking to the docs somewhere in the UI with it being a little bit more advanced and prone to user error? If so, @criamico mentioned it in the issue, but the docs dont explicitly lay out the multi-format string as being an option, so we likely need to get those up-to-date as well.

[kpollich]

@kpollich Also, do you think its worth maybe linking to the docs somewhere in the UI with it being a little bit more advanced and prone to user error? If so, @criamico mentioned it in the issue, but the docs dont explicitly lay out the multi-format string as being an option, so we likely need to get those up-to-date as well.

Yeah we can link to those docs and probably file an issue in https://github.com/elastic/ingest-docs to get those filebeat docs updated to go into more detail about the dynamic topic syntax.

[kpollich]

One last thing to update and this will be good to go from me

[kpollich]

Awesome work 🚀

[kilfoyle]

Yeah we can link to those docs and probably file an issue in https://github.com/elastic/ingest-docs to get those filebeat docs updated to go into more detail about the dynamic topic syntax.

@kpollich I hope it's okay: I transferred this docs issue into the beats repo (elastic/beats#42932) since (as far as I know) the ingest-docs repo has been used only for Fleet & Elastic Agent updates. This may all change soon though with the docs migration.

Thanks for opening it @Supplementing!

[Supplementing]

@elasticmachine merge upstream

[elasticmachine]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: 42145e7

Failed CI Steps

• Fleet Cypress Tests #1

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
aiAssistantManagementSelection	92.5KB	92.6KB	+65.0B
fleet	1.7MB	1.7MB	+797.0B
lists	136.5KB	136.6KB	+65.0B
total			+927.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
core	474.6KB	474.7KB	+65.0B

History

• 💚 Build #279732 succeeded bfccfdb
• 💔 Build #279720 failed 44c3a46
• 💔 Build #279691 failed fdd2cd5
• 💔 Build #279573 failed d99c2b7
• 💚 Build #279252 succeeded 91da3c7
• 💚 Build #279193 succeeded 76f1af5

[kilfoyle]

LGTM! 🚢

Just one super small suggestion for the error text.