Rename FindingsBaseEsQuery interface in CSP package #212427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertoblaz
added
release_note:skip
7 tasks
albertoblaz
force-pushed
the
rename-csp-base-query
branch
from
23ac305 to
e5db2e8
Compare
albertoblaz
force-pushed
the
rename-csp-base-query
branch
from
e5db2e8 to
37d1c8b
Compare
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
alexreal1314
approved these changes
Feb 27, 2025
|
Starting backport for target branches: 9.0 |
💚 Build Succeeded
Metrics [docs]
History
cc @albertoblaz |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
albertoblaz
added a commit
to albertoblaz/kibana
that referenced
this pull request
Feb 27, 2025
Rename the `FindingsBaseEsQuery` interface exposed by the `@kibana/cloud-security-posture` package as well as all references where it's imported. Separating this renaming into its own PR also lets us tag it with `backport:prev-minor` and avoid potential merge conflicts in the future. - elastic#210938 - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) No risk whatsoever. (cherry picked from commit aac8413)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
albertoblaz
added a commit
that referenced
this pull request
Feb 27, 2025
…212636) # Backport This will backport the following commits from `main` to `8.x`: - [Rename FindingsBaseEsQuery interface in CSP package (#212427)](#212427) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alberto Blázquez","email":"albertoblaz@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-27T10:20:06Z","message":"Rename FindingsBaseEsQuery interface in CSP package (#212427)\n\n## Summary\n\nRename the `FindingsBaseEsQuery` interface exposed by the\n`@kibana/cloud-security-posture` package as well as all references where\nit's imported.\n\nSeparating this renaming into its own PR also lets us tag it with\n`backport:prev-minor` and avoid potential merge conflicts in the future.\n\n### Depends on\n\n- https://github.com/elastic/kibana/pull/210938\n\n### Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n### Identify risks\n\nNo risk whatsoever.","sha":"aac841353dabe25974dfb661c9f4b591eb8fe42b","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Cloud Security","backport:prev-minor","v9.1.0"],"title":"Rename FindingsBaseEsQuery interface in CSP package","number":212427,"url":"https://github.com/elastic/kibana/pull/212427","mergeCommit":{"message":"Rename FindingsBaseEsQuery interface in CSP package (#212427)\n\n## Summary\n\nRename the `FindingsBaseEsQuery` interface exposed by the\n`@kibana/cloud-security-posture` package as well as all references where\nit's imported.\n\nSeparating this renaming into its own PR also lets us tag it with\n`backport:prev-minor` and avoid potential merge conflicts in the future.\n\n### Depends on\n\n- https://github.com/elastic/kibana/pull/210938\n\n### Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n### Identify risks\n\nNo risk whatsoever.","sha":"aac841353dabe25974dfb661c9f4b591eb8fe42b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212427","number":212427,"mergeCommit":{"message":"Rename FindingsBaseEsQuery interface in CSP package (#212427)\n\n## Summary\n\nRename the `FindingsBaseEsQuery` interface exposed by the\n`@kibana/cloud-security-posture` package as well as all references where\nit's imported.\n\nSeparating this renaming into its own PR also lets us tag it with\n`backport:prev-minor` and avoid potential merge conflicts in the future.\n\n### Depends on\n\n- https://github.com/elastic/kibana/pull/210938\n\n### Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n### Identify risks\n\nNo risk whatsoever.","sha":"aac841353dabe25974dfb661c9f4b591eb8fe42b"}}]}] BACKPORT-->
albertoblaz
added a commit
that referenced
this pull request
Feb 27, 2025
…212635) # Backport This will backport the following commits from `main` to `9.0`: - [Rename FindingsBaseEsQuery interface in CSP package (#212427)](#212427) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alberto Blázquez","email":"albertoblaz@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-27T10:20:06Z","message":"Rename FindingsBaseEsQuery interface in CSP package (#212427)\n\n## Summary\n\nRename the `FindingsBaseEsQuery` interface exposed by the\n`@kibana/cloud-security-posture` package as well as all references where\nit's imported.\n\nSeparating this renaming into its own PR also lets us tag it with\n`backport:prev-minor` and avoid potential merge conflicts in the future.\n\n### Depends on\n\n- https://github.com/elastic/kibana/pull/210938\n\n### Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n### Identify risks\n\nNo risk whatsoever.","sha":"aac841353dabe25974dfb661c9f4b591eb8fe42b","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Cloud Security","backport:prev-minor","v9.1.0"],"title":"Rename FindingsBaseEsQuery interface in CSP package","number":212427,"url":"https://github.com/elastic/kibana/pull/212427","mergeCommit":{"message":"Rename FindingsBaseEsQuery interface in CSP package (#212427)\n\n## Summary\n\nRename the `FindingsBaseEsQuery` interface exposed by the\n`@kibana/cloud-security-posture` package as well as all references where\nit's imported.\n\nSeparating this renaming into its own PR also lets us tag it with\n`backport:prev-minor` and avoid potential merge conflicts in the future.\n\n### Depends on\n\n- https://github.com/elastic/kibana/pull/210938\n\n### Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n### Identify risks\n\nNo risk whatsoever.","sha":"aac841353dabe25974dfb661c9f4b591eb8fe42b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212427","number":212427,"mergeCommit":{"message":"Rename FindingsBaseEsQuery interface in CSP package (#212427)\n\n## Summary\n\nRename the `FindingsBaseEsQuery` interface exposed by the\n`@kibana/cloud-security-posture` package as well as all references where\nit's imported.\n\nSeparating this renaming into its own PR also lets us tag it with\n`backport:prev-minor` and avoid potential merge conflicts in the future.\n\n### Depends on\n\n- https://github.com/elastic/kibana/pull/210938\n\n### Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n### Identify risks\n\nNo risk whatsoever.","sha":"aac841353dabe25974dfb661c9f4b591eb8fe42b"}}]}] BACKPORT-->
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Mar 4, 2025
…2427) (elastic#212636) # Backport This will backport the following commits from `main` to `8.x`: - [Rename FindingsBaseEsQuery interface in CSP package (elastic#212427)](elastic#212427) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alberto Blázquez","email":"albertoblaz@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-27T10:20:06Z","message":"Rename FindingsBaseEsQuery interface in CSP package (elastic#212427)\n\n## Summary\n\nRename the `FindingsBaseEsQuery` interface exposed by the\n`@kibana/cloud-security-posture` package as well as all references where\nit's imported.\n\nSeparating this renaming into its own PR also lets us tag it with\n`backport:prev-minor` and avoid potential merge conflicts in the future.\n\n### Depends on\n\n- https://github.com/elastic/kibana/pull/210938\n\n### Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n### Identify risks\n\nNo risk whatsoever.","sha":"aac841353dabe25974dfb661c9f4b591eb8fe42b","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Cloud Security","backport:prev-minor","v9.1.0"],"title":"Rename FindingsBaseEsQuery interface in CSP package","number":212427,"url":"https://github.com/elastic/kibana/pull/212427","mergeCommit":{"message":"Rename FindingsBaseEsQuery interface in CSP package (elastic#212427)\n\n## Summary\n\nRename the `FindingsBaseEsQuery` interface exposed by the\n`@kibana/cloud-security-posture` package as well as all references where\nit's imported.\n\nSeparating this renaming into its own PR also lets us tag it with\n`backport:prev-minor` and avoid potential merge conflicts in the future.\n\n### Depends on\n\n- https://github.com/elastic/kibana/pull/210938\n\n### Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n### Identify risks\n\nNo risk whatsoever.","sha":"aac841353dabe25974dfb661c9f4b591eb8fe42b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212427","number":212427,"mergeCommit":{"message":"Rename FindingsBaseEsQuery interface in CSP package (elastic#212427)\n\n## Summary\n\nRename the `FindingsBaseEsQuery` interface exposed by the\n`@kibana/cloud-security-posture` package as well as all references where\nit's imported.\n\nSeparating this renaming into its own PR also lets us tag it with\n`backport:prev-minor` and avoid potential merge conflicts in the future.\n\n### Depends on\n\n- https://github.com/elastic/kibana/pull/210938\n\n### Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n### Identify risks\n\nNo risk whatsoever.","sha":"aac841353dabe25974dfb661c9f4b591eb8fe42b"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rename the
FindingsBaseEsQueryinterface exposed by the@kibana/cloud-security-posturepackage as well as all references where it's imported.Separating this renaming into its own PR also lets us tag it with
backport:prev-minorand avoid potential merge conflicts in the future.Depends on
Checklist
release_note:*label is applied per the guidelinesIdentify risks
No risk whatsoever.