Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.18] [Security Solution] Convert isolate host to standalone flyout (#211853) #212433

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.18:

Questions ?

Please refer to the Backport tool documentation

…c#211853)

## Summary

Ref: elastic#207596

This PR fixed a bug where when user has a alert open in preview, then
clicks isolate/release host, the panel opens in the background. This is
because the isolate host panel was called via `openRightPanel`, which
only replaces the panel and not opens a new flyout. To make the isolate
host flyout consistent with other actions, this PR converts the panel
into a normal EUI flyout.

https://github.com/user-attachments/assets/7da4baa0-61ee-4166-9ff1-57c1078a1547

**How to test**
- Apply license (platinum+)
- To enable the isolate/release host button, you can use this command
`yarn test:generate --fleet --withNewUser=test:changeme`

### Checklist

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 74e1320)
@kibanamachine kibanamachine merged commit 171541e into elastic:8.18 Feb 25, 2025
11 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.1MB 9.1MB +1.1KB

cc @christineweng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants