Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Cloud Defend Telemetry #212496

Merged
merged 4 commits into from
Mar 3, 2025
Merged

Deprecate Cloud Defend Telemetry #212496

merged 4 commits into from
Mar 3, 2025

Conversation

CohenIdo
Copy link
Contributor

@CohenIdo CohenIdo commented Feb 26, 2025 •
edited by kibanamachine
Loading

solves:

Summary

As part of the Cloud Defend deprecation, this PR specifically deprecates Cloud Defend telemetry to address the error log issue.

How to test

Before this change, telemetry iteration—whether triggered by the Task Manager background task or manually via the API—generated an error log.

  1. Call the telemetry API using Kibana Dev Tools.
POST kbn:/internal/telemetry/clusters/_stats?apiVersion=2
{
"unencrypted": true
}
  1. Check for error logs.

With this update, the error log no longer appear.

@CohenIdo CohenIdo added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:Cloud Security Cloud Security team related labels Feb 26, 2025
@CohenIdo CohenIdo marked this pull request as ready for review February 26, 2025 10:42
@CohenIdo CohenIdo requested review from a team as code owners February 26, 2025 10:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@CohenIdo CohenIdo added the backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) label Feb 26, 2025
@CohenIdo CohenIdo removed the v9.0.0 label Feb 26, 2025
@CohenIdo CohenIdo linked an issue Feb 26, 2025 that may be closed by this pull request
Error "PackageNotFoundError: [cloud_defend] package not found in registry" on Kibana startup #212241
Closed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
cloudDefend 6 4 -2

History

gsoldevila
gsoldevila approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@gsoldevila gsoldevila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! IIUC these fields will no longer be shipped / ingested.
Is there any impact on telemetry-cluster side? I'm thinking:

  • Mapped fields that won't be populated anymore, is there a way to clean those up?
  • If there are any consumers of these fields (dashboards, alerts, slos?), will they error?

@CohenIdo
Copy link
Contributor Author

CohenIdo commented Mar 3, 2025

Thanks for the review @gsoldevila.

Mapped fields that won't be populated anymore, is there a way to clean those up?
I cleaned them here.
If there are any consumers of these fields (dashboards, alerts, slos?), will they error?
Good point, and yes already aligned with this change also in the dashboard side. .

@CohenIdo CohenIdo merged commit 58e25b5 into elastic:main Mar 3, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 9.0

https://github.com/elastic/kibana/actions/runs/13628706032

@kibanamachine kibanamachine mentioned this pull request Mar 3, 2025
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Mar 3, 2025
@kibanamachine @CohenIdo
[9.0] Deprecate Cloud Defend Telemetry (#212874)
763231f 
# Backport

This will backport the following commits from `main` to `9.0`:
- [Deprecate Cloud Defend
Telemetry](#212496)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Ido
Cohen","email":"90558359+CohenIdo@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-03T10:28:37Z","message":"Deprecate
Cloud Defend
Telemetry","sha":"58e25b564e6b80816b8c8800e109021b1d30fc5a","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Cloud
Security","backport:prev-minor","v9.1.0"],"title":"Deprecate Cloud
Defend
Telemetry","number":212496,"url":"https://github.com/elastic/kibana/pull/212496","mergeCommit":{"message":"Deprecate
Cloud Defend
Telemetry","sha":"58e25b564e6b80816b8c8800e109021b1d30fc5a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212496","number":212496,"mergeCommit":{"message":"Deprecate
Cloud Defend
Telemetry","sha":"58e25b564e6b80816b8c8800e109021b1d30fc5a"}}]}]
BACKPORT-->

Co-authored-by: Ido Cohen <90558359+CohenIdo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxcold maxcold maxcold approved these changes

@gsoldevila gsoldevila gsoldevila approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v9.0.0 v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error "PackageNotFoundError: [cloud_defend] package not found in registry" on Kibana startup
5 participants
@CohenIdo @elasticmachine @kibanamachine @maxcold @gsoldevila