Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ResponseOps]consistent-type-imports linting rule for RO packages/plugins - PR3 #212498

Open
wants to merge 45 commits into
base: main
Choose a base branch
from
Open

[ResponseOps]consistent-type-imports linting rule for RO packages/plugins - PR3 #212498

wants to merge 45 commits into from
+1,068 −977

Conversation

georgianaonoleata1904
Copy link
Contributor

@georgianaonoleata1904 georgianaonoleata1904 commented Feb 26, 2025 •
edited
Loading

  • Enabled @typescript-eslint/consistent-type-imports eslint rule for ResponseOps packages and plugins:

    • this rule ensures that imports used only for type declarations are consistently written using import type syntax

  • fixed type imports in:

    • x-pack/platform/plugins/shared/event_log
    • x-pack/platform/plugins/shared/rule_registry
    • x-pack/platform/plugins/shared/task_manager
    • x-pack/solutions/observability/packages/kbn-alerts-grouping
    • src/platform/packages/shared/kbn-alerts-ui-shared
    • src/platform/packages/shared/kbn-alerting-types
    • src/platform/packages/shared/kbn-cases-components
    • src/platform/packages/shared/kbn-actions-types
    • src/platform/packages/shared/kbn-alerts-as-data-utils
    • src/platform/packages/shared/kbn-grouping
    • src/platform/packages/shared/kbn-rrule
    • src/platform/packages/shared/kbn-rule-data-utils
    • src/platform/packages/shared/kbn-triggers-actions-ui-types
    • x-pack/platform/packages/shared/kbn-alerting-comparators

georgianaonoleata1904 and others added 15 commits February 26, 2025 12:40
@georgianaonoleata1904
added eslint rule for consistent-type-imports and fixed imports for e…
8eadf3a 
…vent_log
@georgianaonoleata1904
fixed type imports for rule_registry
314c5ab
@georgianaonoleata1904
fixed type imports for task_manager
84708f6
@georgianaonoleata1904
fixed type imports for kbn-alerts-shared and kbn-alerts-grouping
b443b7c
@georgianaonoleata1904
fixed type imports for kbn-alerting-types
dae62eb
@georgianaonoleata1904
fixed type imports for kbn-cases-components and kbn-alerts-as-data-utils
5f6a10e
@georgianaonoleata1904
fixed type imports for kbn-grouping, kbn-rrule, kbn-rule-data-utils, …
7dda587 
…kbn-triggers-actions-ui-types
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
9522394
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
a82fcdd 
…-fix'
@georgianaonoleata1904
Merge branch 'main' into type-imports-eslint-ro-3
113cb23
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
ede6ecf
@georgianaonoleata1904
Merge branch 'main' into type-imports-eslint-ro-3
da41282
@georgianaonoleata1904
added missing import type
f8f0c77
@georgianaonoleata1904
Merge branch 'type-imports-eslint-ro-3' of https://github.com/georgia…
8ab563e 
…naonoleata1904/kibana into type-imports-eslint-ro-3
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
8b5c75e
@georgianaonoleata1904 georgianaonoleata1904 self-assigned this Mar 4, 2025
@georgianaonoleata1904 georgianaonoleata1904 added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) backport:version Backport to applied version labels v9.1.0 v8.19.0 labels Mar 4, 2025
@georgianaonoleata1904 georgianaonoleata1904 marked this pull request as ready for review March 4, 2025 09:33
@georgianaonoleata1904 georgianaonoleata1904 requested review from a team as code owners March 4, 2025 09:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@georgianaonoleata1904 georgianaonoleata1904 changed the title WIP - [ResponseOps] consistent-type-imports linting rule for RO packages/plugins [ResponseOps]consistent-type-imports linting rule for RO packages/plugins - PR3 Mar 4, 2025
@georgianaonoleata1904 georgianaonoleata1904 mentioned this pull request Mar 4, 2025
Open
kibanamachine and others added 14 commits March 4, 2025 10:09
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
7c5270c
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
ed8d200 
…-fix'
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
df9ca35
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
ffdba0d 
…-fix'
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
f8aed6b
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
0de734a 
…-fix'
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
ac7847e
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
fc462c2 
…-fix'
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
c6e5ce3
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
f61723c 
…-fix'
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
1ff9d6c
@georgianaonoleata1904
Merge branch 'main' into type-imports-eslint-ro-3
49ce1df
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
bbc6e3e 
…-fix'
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
7ad013e
@georgianaonoleata1904
Copy link
Contributor Author

/ci

kibanamachine and others added 14 commits March 5, 2025 09:15
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
9e73ac8 
…-fix'
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
e99eeff
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
24fec8f 
…-fix'
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
0418dcf
@georgianaonoleata1904
Merge branch 'main' into type-imports-eslint-ro-3
66e0eb5
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
24b78ec 
…-fix'
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
ab38297
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
486d163 
…-fix'
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
6024877
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
8249fde 
…-fix'
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
70156e2
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
6c934fd 
…-fix'
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
a85aeb0
@georgianaonoleata1904
Merge branch 'main' into type-imports-eslint-ro-3
7e48068
@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 6, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @georgianaonoleata1904

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@georgianaonoleata1904 georgianaonoleata1904

Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.19.0 v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@georgianaonoleata1904 @elasticmachine @kibanamachine