Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.18] [Synthetics] Fix overview error popover !! (#211431) #212620

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

shahzad31
Copy link
Contributor

Backport

This will backport the following commits from main to 8.18:

Questions ?

Please refer to the Backport tool documentation

Fix overview error popover !!

Pings aren't being returned as part of overview data anymore, so had to
add redux actions to fetch it separately via an existing API

Fixes elastic#211745

<img width="1728" alt="image"
src="https://github.com/user-attachments/assets/2244948f-e42d-443d-b6e7-42e0a72b1bfa"
/>

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Justin Kambic <jk@elastic.co>
(cherry picked from commit aaf73ff)
@shahzad31 shahzad31 enabled auto-merge (squash) February 27, 2025 11:03
@botelastic botelastic bot added the Team:obs-ux-management Observability Management User Experience Team label Feb 27, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
synthetics 961 964 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 788.6KB 792.0KB +3.4KB

Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahzad31 shahzad31 merged commit 8dd76be into elastic:8.18 Feb 27, 2025
8 checks passed
@shahzad31 shahzad31 deleted the backport/8.18/pr-211431 branch February 27, 2025 14:03
shahzad31 added a commit that referenced this pull request Mar 6, 2025
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Synthetics] Fix overview error popover !!
(#211431)](#211431)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2025-02-21T16:38:54Z","message":"[Synthetics]
Fix overview error popover !! (#211431)\n\n## Summary\n\nFix overview
error popover !!\n\nPings aren't being returned as part of overview data
anymore, so had to\nadd redux actions to fetch it separately via an
existing API\n\nFixes
https://github.com/elastic/kibana/issues/211745\n\n\n<img width=\"1728\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/2244948f-e42d-443d-b6e7-42e0a72b1bfa\"\n/>\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by:
Justin Kambic
<jk@elastic.co>","sha":"aaf73ff5f67a9163773ff43868f329e3b5693242","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:obs-ux-management","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Synthetics]
Fix overview error popover
!!","number":211431,"url":"https://github.com/elastic/kibana/pull/211431","mergeCommit":{"message":"[Synthetics]
Fix overview error popover !! (#211431)\n\n## Summary\n\nFix overview
error popover !!\n\nPings aren't being returned as part of overview data
anymore, so had to\nadd redux actions to fetch it separately via an
existing API\n\nFixes
https://github.com/elastic/kibana/issues/211745\n\n\n<img width=\"1728\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/2244948f-e42d-443d-b6e7-42e0a72b1bfa\"\n/>\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by:
Justin Kambic
<jk@elastic.co>","sha":"aaf73ff5f67a9163773ff43868f329e3b5693242"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/212123","number":212123,"state":"MERGED","mergeCommit":{"sha":"83e37babbff8e702c51c2746c790930510f4ccb4","message":"[9.0]
[Synthetics] Fix overview error popover !! (#211431) (#212123)\n\n#
Backport\n\nThis will backport the following commits from `main` to
`9.0`:\n- [[Synthetics] Fix overview error popover
!!\n(#211431)](https://github.com/elastic/kibana/pull/211431)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by:
Shahzad
<shahzad31comp@gmail.com>"}},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/212620","number":212620,"state":"MERGED","mergeCommit":{"sha":"8dd76bedd8ede4bbd28e4037fe3a584507142e2d","message":"[8.18]
[Synthetics] Fix overview error popover !! (#211431) (#212620)\n\n#
Backport\n\nThis will backport the following commits from `main` to
`8.18`:\n- [[Synthetics] Fix overview error popover
!!\n(#211431)](https://github.com/elastic/kibana/pull/211431)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>"}},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211431","number":211431,"mergeCommit":{"message":"[Synthetics]
Fix overview error popover !! (#211431)\n\n## Summary\n\nFix overview
error popover !!\n\nPings aren't being returned as part of overview data
anymore, so had to\nadd redux actions to fetch it separately via an
existing API\n\nFixes
https://github.com/elastic/kibana/issues/211745\n\n\n<img width=\"1728\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/2244948f-e42d-443d-b6e7-42e0a72b1bfa\"\n/>\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by:
Justin Kambic
<jk@elastic.co>","sha":"aaf73ff5f67a9163773ff43868f329e3b5693242"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants