[SecuritySolution] Fix add to library action #212659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angorayc
added
bug
|
Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore) |
angorayc
added
backport:prev-minor
michaelolo24
approved these changes
Mar 3, 2025
|
Starting backport for target branches: 8.18, 8.x, 9.0 |
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 3, 2025
## Summary Add to library actions are not working. Issue description and steps to reproduce: elastic#212650 Update according to SaveModalComponent change: https://github.com/elastic/kibana/pull/186642/files#diff-137261ad728b083fd39cb5d6b58d7afd3d4c4e24749b78609a9aa4b3c63e4170R290 https://github.com/user-attachments/assets/a0d0e81e-5a0f-4462-b110-370894c6bf36 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co> (cherry picked from commit 24d2cd3)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 3, 2025
## Summary Add to library actions are not working. Issue description and steps to reproduce: elastic#212650 Update according to SaveModalComponent change: https://github.com/elastic/kibana/pull/186642/files#diff-137261ad728b083fd39cb5d6b58d7afd3d4c4e24749b78609a9aa4b3c63e4170R290 https://github.com/user-attachments/assets/a0d0e81e-5a0f-4462-b110-370894c6bf36 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co> (cherry picked from commit 24d2cd3)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 3, 2025
## Summary Add to library actions are not working. Issue description and steps to reproduce: elastic#212650 Update according to SaveModalComponent change: https://github.com/elastic/kibana/pull/186642/files#diff-137261ad728b083fd39cb5d6b58d7afd3d4c4e24749b78609a9aa4b3c63e4170R290 https://github.com/user-attachments/assets/a0d0e81e-5a0f-4462-b110-370894c6bf36 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co> (cherry picked from commit 24d2cd3)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 3, 2025
# Backport This will backport the following commits from `main` to `8.18`: - [[SecuritySolution] Fix add to library action (#212659)](#212659) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Angela Chuang","email":"6295984+angorayc@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-03T16:33:10Z","message":"[SecuritySolution] Fix add to library action (#212659)\n\n## Summary\n\nAdd to library actions are not working.\nIssue description and steps to reproduce:\nhttps://github.com//issues/212650\n\n\nUpdate according to SaveModalComponent change:\nhttps://github.com//pull/186642/files#diff-137261ad728b083fd39cb5d6b58d7afd3d4c4e24749b78609a9aa4b3c63e4170R290\n\n\nhttps://github.com/user-attachments/assets/a0d0e81e-5a0f-4462-b110-370894c6bf36\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>","sha":"24d2cd3e4f31fd75c6481934119ca380931cd6d0","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","Team:Threat Hunting:Explore","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[SecuritySolution] Fix add to library action","number":212659,"url":"https://github.com/elastic/kibana/pull/212659","mergeCommit":{"message":"[SecuritySolution] Fix add to library action (#212659)\n\n## Summary\n\nAdd to library actions are not working.\nIssue description and steps to reproduce:\nhttps://github.com//issues/212650\n\n\nUpdate according to SaveModalComponent change:\nhttps://github.com//pull/186642/files#diff-137261ad728b083fd39cb5d6b58d7afd3d4c4e24749b78609a9aa4b3c63e4170R290\n\n\nhttps://github.com/user-attachments/assets/a0d0e81e-5a0f-4462-b110-370894c6bf36\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>","sha":"24d2cd3e4f31fd75c6481934119ca380931cd6d0"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212659","number":212659,"mergeCommit":{"message":"[SecuritySolution] Fix add to library action (#212659)\n\n## Summary\n\nAdd to library actions are not working.\nIssue description and steps to reproduce:\nhttps://github.com//issues/212650\n\n\nUpdate according to SaveModalComponent change:\nhttps://github.com//pull/186642/files#diff-137261ad728b083fd39cb5d6b58d7afd3d4c4e24749b78609a9aa4b3c63e4170R290\n\n\nhttps://github.com/user-attachments/assets/a0d0e81e-5a0f-4462-b110-370894c6bf36\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>","sha":"24d2cd3e4f31fd75c6481934119ca380931cd6d0"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Angela Chuang <6295984+angorayc@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Mar 3, 2025
# Backport This will backport the following commits from `main` to `9.0`: - [[SecuritySolution] Fix add to library action (#212659)](#212659) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Angela Chuang","email":"6295984+angorayc@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-03T16:33:10Z","message":"[SecuritySolution] Fix add to library action (#212659)\n\n## Summary\n\nAdd to library actions are not working.\nIssue description and steps to reproduce:\nhttps://github.com//issues/212650\n\n\nUpdate according to SaveModalComponent change:\nhttps://github.com//pull/186642/files#diff-137261ad728b083fd39cb5d6b58d7afd3d4c4e24749b78609a9aa4b3c63e4170R290\n\n\nhttps://github.com/user-attachments/assets/a0d0e81e-5a0f-4462-b110-370894c6bf36\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>","sha":"24d2cd3e4f31fd75c6481934119ca380931cd6d0","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","Team:Threat Hunting:Explore","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[SecuritySolution] Fix add to library action","number":212659,"url":"https://github.com/elastic/kibana/pull/212659","mergeCommit":{"message":"[SecuritySolution] Fix add to library action (#212659)\n\n## Summary\n\nAdd to library actions are not working.\nIssue description and steps to reproduce:\nhttps://github.com//issues/212650\n\n\nUpdate according to SaveModalComponent change:\nhttps://github.com//pull/186642/files#diff-137261ad728b083fd39cb5d6b58d7afd3d4c4e24749b78609a9aa4b3c63e4170R290\n\n\nhttps://github.com/user-attachments/assets/a0d0e81e-5a0f-4462-b110-370894c6bf36\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>","sha":"24d2cd3e4f31fd75c6481934119ca380931cd6d0"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212659","number":212659,"mergeCommit":{"message":"[SecuritySolution] Fix add to library action (#212659)\n\n## Summary\n\nAdd to library actions are not working.\nIssue description and steps to reproduce:\nhttps://github.com//issues/212650\n\n\nUpdate according to SaveModalComponent change:\nhttps://github.com//pull/186642/files#diff-137261ad728b083fd39cb5d6b58d7afd3d4c4e24749b78609a9aa4b3c63e4170R290\n\n\nhttps://github.com/user-attachments/assets/a0d0e81e-5a0f-4462-b110-370894c6bf36\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>","sha":"24d2cd3e4f31fd75c6481934119ca380931cd6d0"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Angela Chuang <6295984+angorayc@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Mar 3, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [[SecuritySolution] Fix add to library action (#212659)](#212659) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Angela Chuang","email":"6295984+angorayc@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-03T16:33:10Z","message":"[SecuritySolution] Fix add to library action (#212659)\n\n## Summary\n\nAdd to library actions are not working.\nIssue description and steps to reproduce:\nhttps://github.com//issues/212650\n\n\nUpdate according to SaveModalComponent change:\nhttps://github.com//pull/186642/files#diff-137261ad728b083fd39cb5d6b58d7afd3d4c4e24749b78609a9aa4b3c63e4170R290\n\n\nhttps://github.com/user-attachments/assets/a0d0e81e-5a0f-4462-b110-370894c6bf36\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>","sha":"24d2cd3e4f31fd75c6481934119ca380931cd6d0","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","Team:Threat Hunting:Explore","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[SecuritySolution] Fix add to library action","number":212659,"url":"https://github.com/elastic/kibana/pull/212659","mergeCommit":{"message":"[SecuritySolution] Fix add to library action (#212659)\n\n## Summary\n\nAdd to library actions are not working.\nIssue description and steps to reproduce:\nhttps://github.com//issues/212650\n\n\nUpdate according to SaveModalComponent change:\nhttps://github.com//pull/186642/files#diff-137261ad728b083fd39cb5d6b58d7afd3d4c4e24749b78609a9aa4b3c63e4170R290\n\n\nhttps://github.com/user-attachments/assets/a0d0e81e-5a0f-4462-b110-370894c6bf36\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>","sha":"24d2cd3e4f31fd75c6481934119ca380931cd6d0"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212659","number":212659,"mergeCommit":{"message":"[SecuritySolution] Fix add to library action (#212659)\n\n## Summary\n\nAdd to library actions are not working.\nIssue description and steps to reproduce:\nhttps://github.com//issues/212650\n\n\nUpdate according to SaveModalComponent change:\nhttps://github.com//pull/186642/files#diff-137261ad728b083fd39cb5d6b58d7afd3d4c4e24749b78609a9aa4b3c63e4170R290\n\n\nhttps://github.com/user-attachments/assets/a0d0e81e-5a0f-4462-b110-370894c6bf36\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>","sha":"24d2cd3e4f31fd75c6481934119ca380931cd6d0"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Angela Chuang <6295984+angorayc@users.noreply.github.com>
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Mar 4, 2025
…lastic#212952) # Backport This will backport the following commits from `main` to `8.x`: - [[SecuritySolution] Fix add to library action (elastic#212659)](elastic#212659) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Angela Chuang","email":"6295984+angorayc@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-03T16:33:10Z","message":"[SecuritySolution] Fix add to library action (elastic#212659)\n\n## Summary\n\nAdd to library actions are not working.\nIssue description and steps to reproduce:\nhttps://github.com/elastic/issues/212650\n\n\nUpdate according to SaveModalComponent change:\nhttps://github.com/elastic/pull/186642/files#diff-137261ad728b083fd39cb5d6b58d7afd3d4c4e24749b78609a9aa4b3c63e4170R290\n\n\nhttps://github.com/user-attachments/assets/a0d0e81e-5a0f-4462-b110-370894c6bf36\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>","sha":"24d2cd3e4f31fd75c6481934119ca380931cd6d0","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","Team:Threat Hunting:Explore","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[SecuritySolution] Fix add to library action","number":212659,"url":"https://github.com/elastic/kibana/pull/212659","mergeCommit":{"message":"[SecuritySolution] Fix add to library action (elastic#212659)\n\n## Summary\n\nAdd to library actions are not working.\nIssue description and steps to reproduce:\nhttps://github.com/elastic/issues/212650\n\n\nUpdate according to SaveModalComponent change:\nhttps://github.com/elastic/pull/186642/files#diff-137261ad728b083fd39cb5d6b58d7afd3d4c4e24749b78609a9aa4b3c63e4170R290\n\n\nhttps://github.com/user-attachments/assets/a0d0e81e-5a0f-4462-b110-370894c6bf36\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>","sha":"24d2cd3e4f31fd75c6481934119ca380931cd6d0"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212659","number":212659,"mergeCommit":{"message":"[SecuritySolution] Fix add to library action (elastic#212659)\n\n## Summary\n\nAdd to library actions are not working.\nIssue description and steps to reproduce:\nhttps://github.com/elastic/issues/212650\n\n\nUpdate according to SaveModalComponent change:\nhttps://github.com/elastic/pull/186642/files#diff-137261ad728b083fd39cb5d6b58d7afd3d4c4e24749b78609a9aa4b3c63e4170R290\n\n\nhttps://github.com/user-attachments/assets/a0d0e81e-5a0f-4462-b110-370894c6bf36\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>","sha":"24d2cd3e4f31fd75c6481934119ca380931cd6d0"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Angela Chuang <6295984+angorayc@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add to library actions are not working.
Issue description and steps to reproduce: #212650
Update according to SaveModalComponent change: https://github.com/elastic/kibana/pull/186642/files#diff-137261ad728b083fd39cb5d6b58d7afd3d4c4e24749b78609a9aa4b3c63e4170R290
Screen.Recording.2025-02-27.at.14.17.12.mov