[ES|QL] Introduces a new package for esql types #212754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
added
v9.1.0
v8.19.0
Feature:ES|QL
|
Pinging @elastic/kibana-esql (Team:ESQL) |
stratoula
changed the title
stratoula
changed the title
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
History
|
jughosta
approved these changes
Feb 28, 2025
src/platform/packages/shared/kbn-esql-validation-autocomplete/BUILD.bazel
Show resolved
Hide resolved
ThomThomson
approved these changes
Feb 28, 2025
markov00
approved these changes
Mar 3, 2025
x-pack/platform/plugins/shared/lens/public/react_embeddable/data_loader.test.ts
Outdated
Show resolved
Hide resolved
…ta_loader.test.ts Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com>
|
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Mar 3, 2025
## Summary The esql types are around many packages and plugins creating problems either with the bundle size or cyclic dependencies. This PR is moving some of them on the esql-types package. I am going to move more there in follow up PRs. (I decided to rename it as it makes more sense to have a generic one for esql rather one only for the variables) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com> (cherry picked from commit dab569b) # Conflicts: # .github/CODEOWNERS
stratoula
added a commit
that referenced
this pull request
Mar 3, 2025
) # Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] Introduces a new package for esql types (#212754)](#212754) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Stratoula Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2025-03-03T11:04:32Z","message":"[ES|QL] Introduces a new package for esql types (#212754)\n\n## Summary\n\nThe esql types are around many packages and plugins creating problems\neither with the bundle size or cyclic dependencies.\n\nThis PR is moving some of them on the esql-types package. I am going to\nmove more there in follow up PRs.\n\n(I decided to rename it as it makes more sense to have a generic one for\nesql rather one only for the variables)\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Marco Vettorello <vettorello.marco@gmail.com>","sha":"dab569b70ac054b1b5416f086b62a54376495def","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL] Introduces a new package for esql types","number":212754,"url":"https://github.com/elastic/kibana/pull/212754","mergeCommit":{"message":"[ES|QL] Introduces a new package for esql types (#212754)\n\n## Summary\n\nThe esql types are around many packages and plugins creating problems\neither with the bundle size or cyclic dependencies.\n\nThis PR is moving some of them on the esql-types package. I am going to\nmove more there in follow up PRs.\n\n(I decided to rename it as it makes more sense to have a generic one for\nesql rather one only for the variables)\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Marco Vettorello <vettorello.marco@gmail.com>","sha":"dab569b70ac054b1b5416f086b62a54376495def"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212754","number":212754,"mergeCommit":{"message":"[ES|QL] Introduces a new package for esql types (#212754)\n\n## Summary\n\nThe esql types are around many packages and plugins creating problems\neither with the bundle size or cyclic dependencies.\n\nThis PR is moving some of them on the esql-types package. I am going to\nmove more there in follow up PRs.\n\n(I decided to rename it as it makes more sense to have a generic one for\nesql rather one only for the variables)\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Marco Vettorello <vettorello.marco@gmail.com>","sha":"dab569b70ac054b1b5416f086b62a54376495def"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Mar 4, 2025
elastic#212880) # Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] Introduces a new package for esql types (elastic#212754)](elastic#212754) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Stratoula Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2025-03-03T11:04:32Z","message":"[ES|QL] Introduces a new package for esql types (elastic#212754)\n\n## Summary\n\nThe esql types are around many packages and plugins creating problems\neither with the bundle size or cyclic dependencies.\n\nThis PR is moving some of them on the esql-types package. I am going to\nmove more there in follow up PRs.\n\n(I decided to rename it as it makes more sense to have a generic one for\nesql rather one only for the variables)\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Marco Vettorello <vettorello.marco@gmail.com>","sha":"dab569b70ac054b1b5416f086b62a54376495def","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL] Introduces a new package for esql types","number":212754,"url":"https://github.com/elastic/kibana/pull/212754","mergeCommit":{"message":"[ES|QL] Introduces a new package for esql types (elastic#212754)\n\n## Summary\n\nThe esql types are around many packages and plugins creating problems\neither with the bundle size or cyclic dependencies.\n\nThis PR is moving some of them on the esql-types package. I am going to\nmove more there in follow up PRs.\n\n(I decided to rename it as it makes more sense to have a generic one for\nesql rather one only for the variables)\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Marco Vettorello <vettorello.marco@gmail.com>","sha":"dab569b70ac054b1b5416f086b62a54376495def"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212754","number":212754,"mergeCommit":{"message":"[ES|QL] Introduces a new package for esql types (elastic#212754)\n\n## Summary\n\nThe esql types are around many packages and plugins creating problems\neither with the bundle size or cyclic dependencies.\n\nThis PR is moving some of them on the esql-types package. I am going to\nmove more there in follow up PRs.\n\n(I decided to rename it as it makes more sense to have a generic one for\nesql rather one only for the variables)\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Marco Vettorello <vettorello.marco@gmail.com>","sha":"dab569b70ac054b1b5416f086b62a54376495def"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The esql types are around many packages and plugins creating problems either with the bundle size or cyclic dependencies.
This PR is moving some of them on the esql-types package. I am going to move more there in follow up PRs.
(I decided to rename it as it makes more sense to have a generic one for esql rather one only for the variables)