Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] Removes unused property from unified search #212772

Merged
merged 2 commits into from
Mar 3, 2025
Merged

[ES|QL] Removes unused property from unified search #212772

merged 2 commits into from
Mar 3, 2025

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Feb 28, 2025 •
edited by kibanamachine
Loading

Summary

Clean ups the unified search props. (Leftovers from when we had both ES|QL and SQL in the dataview picker, now we have none of them)

@stratoula stratoula added release_note:skip Skip the PR/issue when compiling release notes Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana backport:version Backport to applied version labels v9.1.0 v8.19.0 labels Feb 28, 2025
@stratoula stratoula mentioned this pull request Feb 28, 2025
Closed
@stratoula stratoula marked this pull request as ready for review February 28, 2025 14:18
@stratoula stratoula requested review from a team as code owners February 28, 2025 14:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

jughosta
jughosta approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Discovery changes LGTM 👍

mbondyra
mbondyra approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the cleanup!

@stratoula stratoula enabled auto-merge (squash) March 3, 2025 09:01
@stratoula stratoula merged commit 642e8f9 into elastic:main Mar 3, 2025
10 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/13627183038

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cloudSecurityPosture 795 794 -1
dashboard 744 743 -1
data 636 635 -1
dataVisualizer 853 852 -1
discover 1110 1109 -1
esql 206 205 -1
esqlDataGrid 533 532 -1
eventAnnotationListing 713 712 -1
infra 1287 1286 -1
investigateApp 346 345 -1
lens 1787 1786 -1
lists 437 436 -1
maps 1348 1347 -1
ml 2400 2399 -1
observability 1407 1406 -1
observabilityAIAssistantApp 518 517 -1
securitySolution 7110 7109 -1
slo 1008 1007 -1
stackAlerts 274 273 -1
unifiedHistogram 289 288 -1
unifiedSearch 394 393 -1
total -21

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/esql-utils 89 88 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 810.9KB 810.8KB -126.0B
unifiedSearch 358.9KB 358.9KB -42.0B
total -168.0B
Unknown metric groups

API count

id before after diff
@kbn/esql-utils 102 101 -1
unifiedSearch 151 150 -1
total -2

History

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 3, 2025
@stratoula
[ES|QL] Removes unused property from unified search (elastic#212772)
c9685c7 
## Summary

Clean ups the unified search props. (Leftovers from when we had both
ES|QL and SQL in the dataview picker, now we have none of them)

(cherry picked from commit 642e8f9)
@kibanamachine kibanamachine mentioned this pull request Mar 3, 2025
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Mar 3, 2025
@kibanamachine @stratoula
[8.x] [ES|QL] Removes unused property from unified search (#212772) (#…
edf338c 
…212860)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES|QL] Removes unused property from unified search
(#212772)](#212772)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2025-03-03T09:08:34Z","message":"[ES|QL]
Removes unused property from unified search (#212772)\n\n##
Summary\n\nClean ups the unified search props. (Leftovers from when we
had both\nES|QL and SQL in the dataview picker, now we have none of
them)","sha":"642e8f9622945742d0b7b03f5117b0558f667509","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL]
Removes unused property from unified
search","number":212772,"url":"https://github.com/elastic/kibana/pull/212772","mergeCommit":{"message":"[ES|QL]
Removes unused property from unified search (#212772)\n\n##
Summary\n\nClean ups the unified search props. (Leftovers from when we
had both\nES|QL and SQL in the dataview picker, now we have none of
them)","sha":"642e8f9622945742d0b7b03f5117b0558f667509"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212772","number":212772,"mergeCommit":{"message":"[ES|QL]
Removes unused property from unified search (#212772)\n\n##
Summary\n\nClean ups the unified search props. (Leftovers from when we
had both\nES|QL and SQL in the dataview picker, now we have none of
them)","sha":"642e8f9622945742d0b7b03f5117b0558f667509"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Mar 4, 2025
@kibanamachine @stratoula @SoniaSanzV
[8.x] [ES|QL] Removes unused property from unified search (elastic#21…
d532b0b 
…2772) (elastic#212860)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES|QL] Removes unused property from unified search
(elastic#212772)](elastic#212772)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2025-03-03T09:08:34Z","message":"[ES|QL]
Removes unused property from unified search (elastic#212772)\n\n##
Summary\n\nClean ups the unified search props. (Leftovers from when we
had both\nES|QL and SQL in the dataview picker, now we have none of
them)","sha":"642e8f9622945742d0b7b03f5117b0558f667509","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL]
Removes unused property from unified
search","number":212772,"url":"https://github.com/elastic/kibana/pull/212772","mergeCommit":{"message":"[ES|QL]
Removes unused property from unified search (elastic#212772)\n\n##
Summary\n\nClean ups the unified search props. (Leftovers from when we
had both\nES|QL and SQL in the dataview picker, now we have none of
them)","sha":"642e8f9622945742d0b7b03f5117b0558f667509"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212772","number":212772,"mergeCommit":{"message":"[ES|QL]
Removes unused property from unified search (elastic#212772)\n\n##
Summary\n\nClean ups the unified search props. (Leftovers from when we
had both\nES|QL and SQL in the dataview picker, now we have none of
them)","sha":"642e8f9622945742d0b7b03f5117b0558f667509"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jughosta jughosta jughosta approved these changes

@mbondyra mbondyra mbondyra approved these changes

@darnautov darnautov darnautov approved these changes

Assignees
No one assigned
Labels
backport:version Backport to applied version labels Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana v8.19.0 v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@stratoula @elasticmachine @kibanamachine @jughosta @mbondyra @darnautov