[Playground] Increase the height of the indices container #212827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daveyholler
requested changes
Mar 3, 2025
x-pack/solutions/search/plugins/search_playground/public/components/select_indices_flyout.tsx
Outdated
Show resolved
Hide resolved
saikatsarkar056
force-pushed
the
increase_indices
branch
from
dc3c992 to
9e07076
Compare
|
@daveyholler In this PR, I set the limit to a maximum of 100 indices. From a design perspective, what would be the best way to indicate that there may be more than 100 indices, but only 100 are displayed in this view? |
saikatsarkar056
requested review from
TattdCodeMonkey,
daveyholler and
joemcelroy
saikatsarkar056
added
backport:prev-minor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
@saikatsarkar056 - If lazy-loading the list isn't possible then we'd likely have to evaluate moving this to a paginated table? But I believe that there's support for some kind of loading/virtualization to make rendering long indeterminate lists doable. @TattdCodeMonkey probably knows better than I do. |
daveyholler
approved these changes
Mar 4, 2025
|
Starting backport for target branches: 8.18, 8.x, 9.0 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 5, 2025
…2827) This PR increase the height of the container for indices in the playground https://github.com/user-attachments/assets/0fbacb11-ce8e-4566-b07e-b6058de89af0 (cherry picked from commit 1e00a04)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 5, 2025
) (#213180) # Backport This will backport the following commits from `main` to `9.0`: - [[Playground] Increase the height of the indices container (#212827)](#212827) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Saikat Sarkar","email":"132922331+saikatsarkar056@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-05T00:34:42Z","message":"[Playground] Increase the height of the indices container (#212827)\n\nThis PR increase the height of the container for indices in the\nplayground\n\n\n\n\nhttps://github.com/user-attachments/assets/0fbacb11-ce8e-4566-b07e-b6058de89af0","sha":"1e00a04c2b11cf69866bfc255486a286d54654b2","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","v8.18.0","v9.1.0"],"title":"[Playground] Increase the height of the indices container","number":212827,"url":"https://github.com/elastic/kibana/pull/212827","mergeCommit":{"message":"[Playground] Increase the height of the indices container (#212827)\n\nThis PR increase the height of the container for indices in the\nplayground\n\n\n\n\nhttps://github.com/user-attachments/assets/0fbacb11-ce8e-4566-b07e-b6058de89af0","sha":"1e00a04c2b11cf69866bfc255486a286d54654b2"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212827","number":212827,"mergeCommit":{"message":"[Playground] Increase the height of the indices container (#212827)\n\nThis PR increase the height of the container for indices in the\nplayground\n\n\n\n\nhttps://github.com/user-attachments/assets/0fbacb11-ce8e-4566-b07e-b6058de89af0","sha":"1e00a04c2b11cf69866bfc255486a286d54654b2"}}]}] BACKPORT--> Co-authored-by: Saikat Sarkar <132922331+saikatsarkar056@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increase the height of the container for indices in the playground
Screen.Recording.2025-03-04.at.10.45.11.AM.mov