Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] explicitly enable non-GPU options for linux for 8.17 [DO NOT MERGE] #212945

Draft
wants to merge 3 commits into
base: 8.17
Choose a base branch
from
+15 −11
Draft

[Reporting] explicitly enable non-GPU options for linux for 8.17 [DO NOT MERGE] #212945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3608537
add --use-gl=angle --use-angle=swiftshader on reports
pmuellr Mar 3, 2025
9299bca
also add --enable-unsafe-swiftshader since it was mentioned in chrome…
pmuellr Mar 3, 2025
91ef4e2
change screenshotting debug logs to info for cloud visibility
pmuellr Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/kbn-screenshotting-server/src/args.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,10 @@ export const args = ({
flags.push('--enable-gpu');
} else {
flags.push('--disable-gpu');
// see: https://chromium.googlesource.com/chromium/src/+/main/docs/gpu/swiftshader.md#automatic-swiftshader-webgl-fallback-is-deprecated
flags.push('--enable-unsafe-swiftshader');
flags.push('--use-gl=angle');
flags.push('--use-angle=swiftshader');
}

if (os.arch() === 'linux') {
Expand Down
22 changes: 11 additions & 11 deletions x-pack/plugins/screenshotting/server/browsers/chromium/driver_factory/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ export class HeadlessChromiumDriverFactory {
logger.info(`Creating browser page driver`);

const chromiumArgs = this.getChromiumArgs();
logger.debug(`Chromium launch args set to: ${chromiumArgs}`);
logger.info(`Chromium launch args set to: ${chromiumArgs}`);

// We set the viewport width using the client-side layout info to reduce the chances of
// browser reflow. Only the window height is expected to be adjusted dramatically
Expand All @@ -139,7 +139,7 @@ export class HeadlessChromiumDriverFactory {
deviceScaleFactor: defaultViewport.deviceScaleFactor ?? DEFAULT_VIEWPORT.deviceScaleFactor,
};

logger.debug(
logger.info(
`Launching with viewport: width=${viewport.width} height=${viewport.height} scaleFactor=${viewport.deviceScaleFactor}`
);

Expand Down Expand Up @@ -175,15 +175,15 @@ export class HeadlessChromiumDriverFactory {

// Log version info for debugging / maintenance
const versionInfo = await devTools.send('Browser.getVersion');
logger.debug(`Browser version: ${JSON.stringify(versionInfo)}`);
logger.info(`Browser version: ${JSON.stringify(versionInfo)}`);

await page.emulateTimezone(browserTimezone);

// Set the default timeout for all navigation methods to the openUrl timeout
// All waitFor methods have their own timeout config passed in to them
page.setDefaultTimeout(openUrlTimeout);

logger.debug(`Browser page driver created`);
logger.info(`Browser page driver created`);

const childProcess = {
async kill(): Promise<ClosePageResult> {
Expand All @@ -199,7 +199,7 @@ export class HeadlessChromiumDriverFactory {
metrics = getMetrics(startMetrics, endMetrics);
const { cpuInPercentage, memoryInMegabytes } = metrics;

logger.debug(
logger.info(
`Chromium consumed CPU ${cpuInPercentage}% Memory ${memoryInMegabytes}MB`
);
}
Expand All @@ -208,9 +208,9 @@ export class HeadlessChromiumDriverFactory {
}

try {
logger.debug('Attempting to close browser...');
logger.info('Attempting to close browser...');
await browser?.close();
logger.debug('Browser closed.');
logger.info('Browser closed.');
} catch (err) {
// do not throw
logger.error(err);
Expand All @@ -224,7 +224,7 @@ export class HeadlessChromiumDriverFactory {
// Ensure that the browser is closed once the observable completes.
observer.add(() => {
if (page.isClosed()) return; // avoid emitting a log unnecessarily
logger.debug(`It looks like the browser is no longer being used. Closing the browser...`);
logger.info(`It looks like the browser is no longer being used. Closing the browser...`);
void childProcess.kill(); // ignore async
});

Expand All @@ -233,7 +233,7 @@ export class HeadlessChromiumDriverFactory {
terminate$
.pipe(
tap((signal) => {
logger.debug(`Termination signal received: ${signal}`);
logger.info(`Termination signal received: ${signal}`);
}),
ignoreElements()
)
Expand Down Expand Up @@ -263,7 +263,7 @@ export class HeadlessChromiumDriverFactory {
// unsubscribe logic makes a best-effort attempt to delete the user data directory used by chromium
observer.add(() => {
const userDataDir = this.userDataDir;
logger.debug(`deleting chromium user data directory at [${userDataDir}]`);
logger.info(`deleting chromium user data directory at [${userDataDir}]`);
// the unsubscribe function isn't `async` so we're going to make our best effort at
// deleting the userDataDir and if it fails log an error.
del(userDataDir, { force: true }).catch((error) => {
Expand Down Expand Up @@ -327,7 +327,7 @@ export class HeadlessChromiumDriverFactory {

logger
.get(`headless-browser-console:${line.type()}`)
.debug(
.info(
`Message in browser console: { text: "${line.text()?.trim()}", url: ${
line.location()?.url
} }`
Expand Down