-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Playwright initial setup #212970
base: main
Are you sure you want to change the base?
[APM] Playwright initial setup #212970
Conversation
cdbfe93
to
94c4464
Compare
94c4464
to
cf4ee27
Compare
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some nits.
Tested locally and working fine!
await page.waitForSelector( | ||
'[data-test-subj="kbnAppWrapper visibleChrome"] [aria-busy="false"]', | ||
{ state: 'visible' } | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
await page.waitForSelector( | |
'[data-test-subj="kbnAppWrapper visibleChrome"] [aria-busy="false"]', | |
{ state: 'visible' } | |
); | |
await serviceMapPage.waitForPageToLoad(); |
await page.waitForSelector( | ||
'[data-test-subj="kbnAppWrapper visibleChrome"] [aria-busy="false"]', | ||
{ state: 'visible' } | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
await page.waitForSelector( | |
'[data-test-subj="kbnAppWrapper visibleChrome"] [aria-busy="false"]', | |
{ state: 'visible' } | |
); | |
await serviceInventoryPage.waitForPageToLoad(); |
Closes #210178
Summary
This PR adds the initial setup for playwright APM test (follow up of #211430, I am keeping it for reference ). It includes only parallel test setup, which is the recommended way of testing, and uses a
globalSetup
- currently has only APM fixture, but it will be extended in the future. This first step show cases 2 suites running in parallel: service inventory and service map.Testing