Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Playwright initial setup #212970

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

jennypavlova
Copy link
Member

@jennypavlova jennypavlova commented Mar 3, 2025

Closes #210178

Summary

This PR adds the initial setup for playwright APM test (follow up of #211430, I am keeping it for reference ). It includes only parallel test setup, which is the recommended way of testing, and uses a globalSetup - currently has only APM fixture, but it will be extended in the future. This first step show cases 2 suites running in parallel: service inventory and service map.

Testing

  • to run the tests refer to the README

@jennypavlova jennypavlova added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Mar 3, 2025
@jennypavlova jennypavlova self-assigned this Mar 3, 2025
@jennypavlova jennypavlova force-pushed the 210178-apm-playwright-initial-seup branch 4 times, most recently from cdbfe93 to 94c4464 Compare March 4, 2025 16:40
@jennypavlova jennypavlova force-pushed the 210178-apm-playwright-initial-seup branch from 94c4464 to cf4ee27 Compare March 4, 2025 16:41
@jennypavlova jennypavlova marked this pull request as ready for review March 4, 2025 16:46
@jennypavlova jennypavlova requested a review from a team as a code owner March 4, 2025 16:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
apm 68 70 +2

Total ESLint disabled count

id before after diff
apm 81 83 +2

cc @jennypavlova

@rmyz rmyz changed the title [APM] Playwright initial seup [APM] Playwright initial setup Mar 5, 2025
Copy link
Contributor

@rmyz rmyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some nits.

Tested locally and working fine!

Comment on lines +18 to +21
await page.waitForSelector(
'[data-test-subj="kbnAppWrapper visibleChrome"] [aria-busy="false"]',
{ state: 'visible' }
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
await page.waitForSelector(
'[data-test-subj="kbnAppWrapper visibleChrome"] [aria-busy="false"]',
{ state: 'visible' }
);
await serviceMapPage.waitForPageToLoad();

Comment on lines +17 to +20
await page.waitForSelector(
'[data-test-subj="kbnAppWrapper visibleChrome"] [aria-busy="false"]',
{ state: 'visible' }
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
await page.waitForSelector(
'[data-test-subj="kbnAppWrapper visibleChrome"] [aria-busy="false"]',
{ state: 'visible' }
);
await serviceInventoryPage.waitForPageToLoad();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PoC] Migrate to Playwright
4 participants