chore(slo): replace error log level with debug #212975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdelemme
added
release_note:skip
kdelemme
force-pushed
the
chore/slo-logger
branch
from
1da5f71 to
1a4a555
Compare
maryam-saeidi
approved these changes
Mar 4, 2025
| @@ -87,7 +87,7 @@ export class TempSummaryCleanupTask { | |||
| params: {}, | |||
| }); | |||
| } catch (e) { | |||
| this.logger.error(`Error scheduling task, error: ${e}`); | |||
| this.logger.debug(`Error scheduling task, error: ${e}`); | |||
There was a problem hiding this comment.
Just curious, what is the implication of such an error? Does the user need to know about this error, or do we handle it in a meaningful way?
There was a problem hiding this comment.
I was not sure about this one actually, maybe since it's a task, it is better to keep it as an error.
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
|
@maryam-saeidi had to re-request a review from you since you've done it before I opened the PR ;) |
💚 Build Succeeded
Metrics [docs]
cc @kdelemme |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #212972
This PR replaces the info and error log levels with debug since most of these errors are for developers or users. Not operations.