[8.17] [Performance][Security Solution][3/4] - Sourcerer performance (#212482) #212985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c#212482) ## Summary Part 3 of elastic#212173 ### Testing For setup see testing section here: elastic#212173 (comment) Testing this work is a bit more `console.log` related, as the primary aim of many of these changes was to limit the amount of re-renders caused by state changes within many of the sourcerer utils. React is relatively fast at handling many of these re-renders, but considering the widespread usage of `useSourcererDataView` and the top level location of `useInitSourcerer`, it was worth taking care of some low hanging fruit. ### Background The changes in this PR centered around limiting the number of re-renders that were being caused unnecessarily in `useSourcererDataView` and `useInitSourcerer` by identifying some quick wins. Comments regarding the changes can be found in the PR diffs ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### Identify risks --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 98b5280)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
1 task
💚 Build Succeeded
Metrics [docs]Async chunks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.17:Questions ?
Please refer to the Backport tool documentation