[8.18] [Performance][Security Solution][4/4] - General Performance changes (#212488) #212990
+44
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lastic#212488) ## Summary Part 4 (Final) of elastic#212173 ### Testing For setup see testing section here: elastic#212173 (comment) For testing, feel free to add a `console.count('!! - Number of re-renders:)` to `x-pack/solutions/security/plugins/security_solution/public/app/home/index.tsx`. The memoization changes [here](https://github.com/elastic/kibana/pull/212488/files#diff-b0cdd6dc57dd06dba69d90894de8c88a7bb7c71c0e58753f324eb8ba664a0782R18) to the plugin template wrapper, prevented 2 extra re-renders, but there is still an underlying problem of how the `PageTemplateWrapper` is used, as it causes unmounting and remounting of the security views when navigating between pages. The only other change was to rely on React's built in diffing on the alerts page for the page level filters (cherry picked from commit 7f32eb0) # Conflicts: # x-pack/solutions/security/plugins/security_solution/public/detections/pages/detection_engine/detection_engine.tsx
logeekal
reviewed
Mar 4, 2025
| query={query} | ||
| timeRange={pageFiltersTimerange} | ||
| onInit={setDetectionPageFilterHandler} | ||
| indexPattern={indexPattern} |
There was a problem hiding this comment.
I think there is this difference when compared to 9.1 PR because of one of Sourcerer's PR. Not sure if it is significant.
There was a problem hiding this comment.
Yea, I very much expect there most likely will be with the entire sourcerer refactor
PhilippeOberti
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.18:Questions ?
Please refer to the Backport tool documentation