[8.x] [Security Assistant] Conversation pagination refactor (#211831)

oas_docs/output/kibana.serverless.yaml

@@ -40577,9 +40577,6 @@ components:
         id:
           description: The conversation id.
           type: string
-        isDefault:
-          description: Is default conversation.
-          type: boolean
         messages:
           description: The conversation messages.
           items:
@@ -40602,16 +40599,13 @@ components:
           $ref: '#/components/schemas/Security_AI_Assistant_API_ConversationCategory'
           description: The conversation category.
         createdAt:
-          description: The last time conversation was updated.
+          description: The time conversation was created.
           type: string
         excludeFromLastConversationStorage:
           description: excludeFromLastConversationStorage.
           type: boolean
         id:
           $ref: '#/components/schemas/Security_AI_Assistant_API_NonEmptyString'
-        isDefault:
-          description: Is default conversation.
-          type: boolean
         messages:
           description: The conversation messages.
           items:
@@ -40838,7 +40832,6 @@ components:
     Security_AI_Assistant_API_FindConversationsSortField:
       enum:
         - created_at
-        - is_default
         - title
         - updated_at
       type: string

oas_docs/output/kibana.yaml

@@ -28763,9 +28763,6 @@ components:
         id:
           description: The conversation id.
           type: string
-        isDefault:
-          description: Is default conversation.
-          type: boolean
         messages:
           description: The conversation messages.
           items:
@@ -28788,16 +28785,13 @@ components:
           $ref: '#/components/schemas/Security_AI_Assistant_API_ConversationCategory'
           description: The conversation category.
         createdAt:
-          description: The last time conversation was updated.
+          description: The time conversation was created.
           type: string
         excludeFromLastConversationStorage:
           description: excludeFromLastConversationStorage.
           type: boolean
         id:
           $ref: '#/components/schemas/Security_AI_Assistant_API_NonEmptyString'
-        isDefault:
-          description: Is default conversation.
-          type: boolean
         messages:
           description: The conversation messages.
           items:
@@ -29024,7 +29018,6 @@ components:
     Security_AI_Assistant_API_FindConversationsSortField:
       enum:
         - created_at
-        - is_default
         - title
         - updated_at
       type: string

x-pack/platform/packages/shared/kbn-elastic-assistant-common/docs/openapi/ess/elastic_assistant_api_2023_10_31.bundled.schema.yaml

@@ -1179,9 +1179,6 @@ components:
         id:
           description: The conversation id.
           type: string
-        isDefault:
-          description: Is default conversation.
-          type: boolean
         messages:
           description: The conversation messages.
           items:
@@ -1204,16 +1201,13 @@ components:
           $ref: '#/components/schemas/ConversationCategory'
           description: The conversation category.
         createdAt:
-          description: The last time conversation was updated.
+          description: The time conversation was created.
           type: string
         excludeFromLastConversationStorage:
           description: excludeFromLastConversationStorage.
           type: boolean
         id:
           $ref: '#/components/schemas/NonEmptyString'
-        isDefault:
-          description: Is default conversation.
-          type: boolean
         messages:
           description: The conversation messages.
           items:
@@ -1448,7 +1442,6 @@ components:
     FindConversationsSortField:
       enum:
         - created_at
-        - is_default
         - title
         - updated_at
       type: string

x-pack/platform/packages/shared/kbn-elastic-assistant-common/docs/openapi/serverless/elastic_assistant_api_2023_10_31.bundled.schema.yaml

@@ -1179,9 +1179,6 @@ components:
         id:
           description: The conversation id.
           type: string
-        isDefault:
-          description: Is default conversation.
-          type: boolean
         messages:
           description: The conversation messages.
           items:
@@ -1204,16 +1201,13 @@ components:
           $ref: '#/components/schemas/ConversationCategory'
           description: The conversation category.
         createdAt:
-          description: The last time conversation was updated.
+          description: The time conversation was created.
           type: string
         excludeFromLastConversationStorage:
           description: excludeFromLastConversationStorage.
           type: boolean
         id:
           $ref: '#/components/schemas/NonEmptyString'
-        isDefault:
-          description: Is default conversation.
-          type: boolean
         messages:
           description: The conversation messages.
           items:
@@ -1448,7 +1442,6 @@ components:
     FindConversationsSortField:
       enum:
         - created_at
-        - is_default
         - title
         - updated_at
       type: string

x-pack/platform/packages/shared/kbn-elastic-assistant-common/impl/schemas/conversations/common_attributes.gen.ts

@@ -327,7 +327,7 @@ export const ConversationResponse = z.object({
    */
   updatedAt: z.string().optional(),
   /**
-   * The last time conversation was updated.
+   * The time conversation was created.
    */
   createdAt: z.string(),
   replacements: Replacements.optional(),
@@ -340,10 +340,6 @@ export const ConversationResponse = z.object({
    * LLM API configuration.
    */
   apiConfig: ApiConfig.optional(),
-  /**
-   * Is default conversation.
-   */
-  isDefault: z.boolean().optional(),
   /**
    * excludeFromLastConversationStorage.
    */
@@ -403,10 +399,6 @@ export const ConversationCreateProps = z.object({
    * LLM API configuration.
    */
   apiConfig: ApiConfig.optional(),
-  /**
-   * Is default conversation.
-   */
-  isDefault: z.boolean().optional(),
   /**
    * excludeFromLastConversationStorage.
    */

x-pack/platform/packages/shared/kbn-elastic-assistant-common/impl/schemas/conversations/common_attributes.schema.yaml

@@ -316,7 +316,7 @@ components:
           description: The last time conversation was updated.
           type: string
         createdAt:
-          description: The last time conversation was updated.
+          description: The time conversation was created.
           type: string
         replacements:
           $ref: '#/components/schemas/Replacements'
@@ -332,9 +332,6 @@ components:
         apiConfig:
           $ref: '#/components/schemas/ApiConfig'
           description: LLM API configuration.
-        isDefault:
-          description: Is default conversation.
-          type: boolean
         excludeFromLastConversationStorage:
           description: excludeFromLastConversationStorage.
           type: boolean
@@ -393,9 +390,6 @@ components:
         apiConfig:
           $ref: '#/components/schemas/ApiConfig'
           description: LLM API configuration.
-        isDefault:
-          description: Is default conversation.
-          type: boolean
         excludeFromLastConversationStorage:
           description: excludeFromLastConversationStorage.
           type: boolean

x-pack/platform/packages/shared/kbn-elastic-assistant-common/impl/schemas/conversations/find_conversations_route.gen.ts

@@ -21,12 +21,7 @@ import { SortOrder } from '../common_attributes.gen';
 import { ConversationResponse } from './common_attributes.gen';
 
 export type FindConversationsSortField = z.infer<typeof FindConversationsSortField>;
-export const FindConversationsSortField = z.enum([
-  'created_at',
-  'is_default',
-  'title',
-  'updated_at',
-]);
+export const FindConversationsSortField = z.enum(['created_at', 'title', 'updated_at']);
 export type FindConversationsSortFieldEnum = typeof FindConversationsSortField.enum;
 export const FindConversationsSortFieldEnum = FindConversationsSortField.enum;
 

x-pack/platform/packages/shared/kbn-elastic-assistant-common/impl/schemas/conversations/find_conversations_route.schema.yaml

@@ -98,6 +98,5 @@ components:
       type: string
       enum:
         - 'created_at'
-        - 'is_default'
         - 'title'
         - 'updated_at'

x-pack/platform/packages/shared/kbn-elastic-assistant/impl/assistant/api/conversations/conversations.ts

@@ -61,33 +61,40 @@ export const getConversationById = async ({
 };
 
 /**
- * API call for getting all user conversations.
+ * API call for determining whether any user conversations exist
  *
- * @param {Object} options - The options object.
  * @param {HttpSetup} options.http - HttpSetup
  * @param {IToasts} [options.toasts] - IToasts
  * @param {AbortSignal} [options.signal] - AbortSignal
  *
- * @returns {Promise<FetchConversationsResponse>}
+ * @returns {Promise<boolean>}
  */
-export const getUserConversations = async ({
+export const getUserConversationsExist = async ({
   http,
   signal,
   toasts,
 }: {
   http: HttpSetup;
   toasts?: IToasts;
   signal?: AbortSignal | undefined;
-}) => {
+}): Promise<boolean> => {
   try {
-    return await http.fetch<FetchConversationsResponse>(
+    const conversation = await http.fetch<FetchConversationsResponse>(
       ELASTIC_AI_ASSISTANT_CONVERSATIONS_URL_FIND,
       {
         method: 'GET',
         version: API_VERSIONS.public.v1,
         signal,
+        query: {
+          per_page: 1,
+          page: 1,
+          // one field to keep request as small as possible
+          fields: ['title'],
+        },
       }
     );
+
+    return conversation.total > 0;
   } catch (error) {
     toasts?.addError(error.body && error.body.message ? new Error(error.body.message) : error, {
       title: i18n.translate('xpack.elasticAssistant.conversations.getUserConversationsError', {

x-pack/platform/packages/shared/kbn-elastic-assistant/impl/assistant/api/conversations/use_fetch_current_user_conversations.test.tsx

@@ -19,11 +19,8 @@ import { defaultAssistantFeatures } from '@kbn/elastic-assistant-common';
 const http = {
   fetch: jest.fn().mockResolvedValue(defaultAssistantFeatures),
 };
-const onFetch = jest.fn();
-
 const defaultProps = {
   http,
-  onFetch,
   isAssistantEnabled: true,
 } as unknown as UseFetchCurrentUserConversationsParams;
 
@@ -48,14 +45,16 @@ describe('useFetchCurrentUserConversations', () => {
           method: 'GET',
           query: {
             page: 1,
-            per_page: 99,
+            fields: ['id', 'title', 'apiConfig', 'updatedAt'],
+            filter: undefined,
+            per_page: 28,
+            sort_field: 'updated_at',
+            sort_order: 'desc',
           },
           version: '2023-10-31',
           signal: undefined,
         }
       );
-
-      expect(onFetch).toHaveBeenCalled();
     });
   });
 });