[9.0] [Performance][Security Solution][1/4] - Field Browser Performance (#212469) #213021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…astic#212469) ## Summary Part 1 of elastic#212173 ### Testing For setup see testing section here: elastic#212173 (comment) **Areas to test:** - Alert Table (Alerts, Rule Detail, Rule Preview pages) - Security solution field browser component - Flyout table tab. ### Background When investigating the performance of the security solution application, one of the issues that was observed was locking of the page and field browser component when the total number of fields returned were significantly high. This led to cell values not rendering in the alert table, and the field browser in all the security solution pages causing the page to crash. The relevant images can be seen at the bottom of this description In short: The `push(...fields)` is non-performant at scale, and at a significant enough scale (Testing was done with 500k mapped fields), fails to run due to excessive arguments provided to the `push` method. In this PR improvements are made in the `browserFields` transformations that are done for the field browser component, expandable flyout table tab, and alert/rule tables via `CellValue` component. This work was done to get immediate improvements in the security solution UI, but a longer term consideration will be whether or not the `browserFields` is even necessary anymore as a concept based on what is available via the `fields` api. We will revisit once our Sourcerer refactoring work is done. <img width="1728" alt="Screenshot 2025-02-26 at 10 15 29 AM" src="https://github.com/user-attachments/assets/a25f577f-f758-415e-9c93-5452eadb8020" /> <img width="1445" alt="Screenshot 2025-02-26 at 10 18 36 AM" src="https://github.com/user-attachments/assets/d70970d3-991a-47ba-b617-5862d18101b6" /> <img width="1469" alt="Screenshot 2025-02-26 at 10 19 48 AM" src="https://github.com/user-attachments/assets/1767aa9b-66ab-46be-bc1a-5311630c2765" />   ### After the fix (Done on [this branch](elastic#212173) that has the other changes as well) https://github.com/user-attachments/assets/da992296-4eb8-49d4-96ca-b0a19a00f1f0 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 750e156) # Conflicts: # x-pack/platform/plugins/shared/triggers_actions_ui/public/application/sections/field_browser/components/field_items/field_items.tsx
1 task
💚 Build Succeeded
Metrics [docs]Async chunks
|
PhilippeOberti
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.0:Questions ?
Please refer to the Backport tool documentation