[ES|QL] Correct the lens_map_to_columns function call arguments #213038
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
|
stratoula
added
release_note:skip
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 4, 2025
…tic#213038) ## Summary The else is being called atm only in Discover ES|QL mode, when the user is typing stats or keep. The `isTextBased` flag is missing which means that we don't call the `mapToOriginalColumnsTextBased` but the one for the dsl mode which might cause bugs. I don't think that Peter had any reason to do so, it seems more as it slipped. (cherry picked from commit e24c1c3)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 4, 2025
…#213038) (#213070) # Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] Correct the lens_map_to_columns function call arguments (#213038)](#213038) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Stratoula Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2025-03-04T10:58:27Z","message":"[ES|QL] Correct the lens_map_to_columns function call arguments (#213038)\n\n## Summary\n\nThe else is being called atm only in Discover ES|QL mode, when the user\nis typing stats or keep.\nThe `isTextBased` flag is missing which means that we don't call the\n`mapToOriginalColumnsTextBased` but the one for the dsl mode which might\ncause bugs.\n\nI don't think that Peter had any reason to do so, it seems more as it\nslipped.","sha":"e24c1c3ee5f69c1c67d39e072ffd36c84bb230e7","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:Lens","Feature:ES|QL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL] Correct the lens_map_to_columns function call arguments","number":213038,"url":"https://github.com/elastic/kibana/pull/213038","mergeCommit":{"message":"[ES|QL] Correct the lens_map_to_columns function call arguments (#213038)\n\n## Summary\n\nThe else is being called atm only in Discover ES|QL mode, when the user\nis typing stats or keep.\nThe `isTextBased` flag is missing which means that we don't call the\n`mapToOriginalColumnsTextBased` but the one for the dsl mode which might\ncause bugs.\n\nI don't think that Peter had any reason to do so, it seems more as it\nslipped.","sha":"e24c1c3ee5f69c1c67d39e072ffd36c84bb230e7"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213038","number":213038,"mergeCommit":{"message":"[ES|QL] Correct the lens_map_to_columns function call arguments (#213038)\n\n## Summary\n\nThe else is being called atm only in Discover ES|QL mode, when the user\nis typing stats or keep.\nThe `isTextBased` flag is missing which means that we don't call the\n`mapToOriginalColumnsTextBased` but the one for the dsl mode which might\ncause bugs.\n\nI don't think that Peter had any reason to do so, it seems more as it\nslipped.","sha":"e24c1c3ee5f69c1c67d39e072ffd36c84bb230e7"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The else is being called atm only in Discover ES|QL mode, when the user is typing stats or keep.
The
isTextBasedflag is missing which means that we don't call themapToOriginalColumnsTextBasedbut the one for the dsl mode which might cause bugs.I don't think that Peter had any reason to do so, it seems more as it slipped.