Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] Follow ups on variables #213040

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Mar 4, 2025

Summary

This PR:

  • add an extra information when hovering over a variable
image
  • passes the variables on the fields retrieval endpoint in the editor to get the fields correctly when there are variables in the query

Checklist

@stratoula stratoula added v9.1.0 v8.19.0 backport:version Backport to applied version labels Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes labels Mar 4, 2025
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/esql-ast 249 250 +1
@kbn/esql-editor 14 15 +1
@kbn/esql-validation-autocomplete 201 200 -1
@kbn/monaco 186 185 -1
total -0

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.5MB 1.5MB +24.0B
stackAlerts 73.2KB 73.2KB +24.0B
total +48.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/esql-ast 26 25 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.6MB 3.6MB +492.0B
Unknown metric groups

API count

id before after diff
@kbn/esql-ast 313 314 +1
@kbn/esql-editor 37 38 +1
@kbn/esql-validation-autocomplete 213 212 -1
@kbn/monaco 186 185 -1
total -0

History

@stratoula stratoula marked this pull request as ready for review March 5, 2025 09:48
@stratoula stratoula requested review from a team as code owners March 5, 2025 09:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana v8.19.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants