[9.0] Make Amsterdam an opt-in theme (#212787) #213093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary This PR updates `DEFAULT_THEME_TAGS` used to determine what theme tags are bundled in Kibana by default to only include the Borealis theme, specifically `borealislight` and `borealisdark` theme tags. This change is expected to decrease bundle sizes significantly and get back to bundling a single theme, not two (4 → 2 theme tags). Now that Serverless, `9.0`, and `main` all run with Borealis, there's no risk in removing Amsterdam from the bundle and decreasing Kibana bundle sizes. We need to keep the feature flag in code for the time being to easily test future Borealis iterations. Amsterdam will still be available as an opt-in theme and is meant to be used locally when testing changes to be backported to 8.x versions that use Amsterdam. To do so, Kibana needs to be started/built with `KBN_OPTIMIZER_THEMES` environment variable set and the feature flag overridden in `kibana.dev.yml`. ```yml # config/kibana.dev.yml feature_flags.overrides.coreRendering.defaultThemeName: amsterdam ``` ```shell # Run dev server with both borealis and Amsterdam theme tags KBN_OPTIMIZER_THEMES="borealislight,borealisdark,v8light,v8dark" yarn start ``` ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 4dd8de8)
1 task
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsasync chunk count
cc @tkajtoch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.0:Questions ?
Please refer to the Backport tool documentation