[SecuritySolution] Register AI Assistant management settings according to productFeatureKeys #213105

angorayc · 2025-03-04T14:25:12Z

Summary

AI Assistant management is registered according to productFeatureKeys set by security_solution_ess or security_solution_serverless plugin.

To verify:

Security project

yarn es serverless --projectType security --kill --clean -E  —ssl xpack.security.authc.api_key.enabled=true
yarn serverless-security --no-base-path

Update xpack.securitySolutionServerless.productTypes in config/serverless.security.yml to switch between essentials and complete tier

Project essentials:

Project complete:

ESS

License trial and enterprise:

yarn es snapshot --license trial -E xpack.security.authc.api_key.enabled=true -E discovery.type=single-node -E network.host=0.0.0.0

Screen.Recording.2025-03-04.at.17.24.35.mov

License basic and others:

yarn es snapshot --license basic -E xpack.security.authc.api_key.enabled=true -E discovery.type=single-node -E network.host=0.0.0.0

Screen.Recording.2025-03-04.at.17.27.35.mov

angorayc · 2025-03-04T14:33:08Z

x-pack/solutions/security/plugins/security_solution_serverless/public/plugin.ts


    this.experimentalFeatures = parseExperimentalConfigValue(
      this.config.enableExperimental,
      securitySolution.experimentalFeatures
    ).features;

+    console.log('serverless setup: setProductFeatureKeys====== ')
+    securitySolution.setProductFeatureKeys(getProductProductFeatures(productTypes));


It setProductFeatureKeys correctly for complete and essential tiers.

angorayc · 2025-03-04T14:36:36Z

x-pack/solutions/security/plugins/security_solution/public/plugin.tsx

+      console.log('productFeatureKeys---',productFeatureKeys);
+      // This seemed to work with serverless but not sure how to deal with ess productFeatureKeys
+
+      const isInProductFeatureKeys = productFeatureKeys && productFeatureKeys.length > 0 && productFeatureKeys.includes(ProductFeatureAssistantKey.assistant);


Running sequence - serverless complete:

Running sequence - serverless essentials:

semd · 2025-03-04T16:37:51Z

x-pack/solutions/security/plugins/security_solution/public/plugin.tsx

+      console.log('productFeatureKeys---',productFeatureKeys);
+      // This seemed to work with serverless but not sure how to deal with ess productFeatureKeys
+
+      const isInProductFeatureKeys = productFeatureKeys && productFeatureKeys.length > 0 && productFeatureKeys.includes(ProductFeatureAssistantKey.assistant);


Can we define the productFeatureKeys$ as a Set<ProductFeatureKeyType>, so we can do:

Suggested change

const isInProductFeatureKeys = productFeatureKeys && productFeatureKeys.length > 0 && productFeatureKeys.includes(ProductFeatureAssistantKey.assistant);

const isInProductFeatureKeys = productFeatureKeys?.has(ProductFeatureAssistantKey.assistant);

It would be nice to have some control to prevent registering this twice, in case more values are emitted.

I check the registration by its id, wdyt? https://github.com/elastic/kibana/pull/213105/files#diff-fa30014b439035af4cc4c875257fb2707ebbeb2f77acb875273129f163db013dR192

kibanamachine · 2025-03-04T18:32:15Z

Project deployed, see credentials at: https://buildkite.com/elastic/kibana-deploy-project-from-pr/builds/351

x-pack/solutions/security/plugins/security_solution_ess/public/plugin.ts

x-pack/solutions/security/plugins/security_solution/public/plugin_contract.ts

x-pack/solutions/security/plugins/security_solution/public/plugin.tsx

…gin_contract.ts Co-authored-by: Sergi Massaneda <sergi.massaneda@gmail.com>

…gin.tsx Co-authored-by: Sergi Massaneda <sergi.massaneda@gmail.com>

elasticmachine · 2025-03-05T11:33:39Z

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

semd

LGTM! 💯

…-fix'

semd · 2025-03-05T12:28:33Z

x-pack/solutions/security/plugins/security_solution/public/plugin.tsx

+        const isAssistantAvailable =
+          productFeatureKeys?.has(ProductFeatureAssistantKey.assistant) &&
+          license?.hasAtLeast('enterprise');


I just realized that if productFeatureKeys is still null, or the license is not defined yet, this code will behave as if the assistant is not available, disabling the assistant management.
Can we add a check for at the beginning?

Suggested change

const isAssistantAvailable =

productFeatureKeys?.has(ProductFeatureAssistantKey.assistant) &&

license?.hasAtLeast('enterprise');

if (!productFeatureKeys || !license) {

return;

}

const isAssistantAvailable =

productFeatureKeys.has(ProductFeatureAssistantKey.assistant) &&

license.hasAtLeast('enterprise');

It seems that as long as we use BehaviorSubject with an initial value, it will always emit the initial value as the first emission. To avoid that, I'd like to replace BehaviorSubject with Subject so the first emission will be the productFeatureKeys from ESS/serverless.
combineLatestWith waits for both productFeatureKeys$ and license$ to emit at least once before emitting a combined value.
In this case, we should be able to always receive the non null values.

Using Subject the subscribe handler will be called only if it is registered before the first next call. If the next happens before the handler is subscribed, it will never be called.
To avoid that, I'm sticking to BehaviorSubject and check if productFeatureKeys and license exists.

elasticmachine · 2025-03-05T19:23:33Z

💔 Build Failed

Buildkite Build
Commit: 6a0d714
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-213105-6a0d71423a8c
Security Deployment

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`securitySolutionEss`	90	93	+3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`securitySolution`	125	127	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	8.9MB	8.9MB	-1.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`securitySolution`	85.5KB	87.5KB	+2.1KB
`securitySolutionEss`	13.6KB	15.2KB	+1.6KB
`securitySolutionServerless`	31.7KB	31.7KB	+74.0B
total			+3.7KB

Unknown metric groups

API count

id	before	after	diff
`securitySolution`	193	195	+2

References to deprecated APIs

id	before	after	diff
`securitySolution`	351	352	+1

History

💔 Build #281154 failed 68d2c9e
💚 Build #281105 succeeded 9025334
💔 Build #281070 failed 93a2c5c

set product feature keys

6ae9b0b

angorayc commented Mar 4, 2025

View reviewed changes

set product feature keys

e5fdb46

angorayc added the ci:project-deploy-security Create a Security Serverless Project label Mar 4, 2025

angorayc mentioned this pull request Mar 4, 2025

[Security Solution] [Bug] AI Assistant for Security setting should not be available from an essential project #212667

Open

semd reviewed Mar 4, 2025

View reviewed changes

set product feature keys

82c6210

angorayc changed the title ~~set product feature keys~~ [SecuritySolution] Register AI Assistant management settings according to productFeatureKeys Mar 4, 2025

angorayc added bug Fixes for quality problems that affect the customer experience Team:Threat Hunting:Explore Team:Security Generative AI Security Generative AI backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Mar 4, 2025

semd reviewed Mar 4, 2025

View reviewed changes

x-pack/solutions/security/plugins/security_solution_ess/public/plugin.ts Outdated Show resolved Hide resolved

semd reviewed Mar 4, 2025

View reviewed changes

x-pack/solutions/security/plugins/security_solution/public/plugin_contract.ts Outdated Show resolved Hide resolved

semd reviewed Mar 4, 2025

View reviewed changes

x-pack/solutions/security/plugins/security_solution/public/plugin.tsx Outdated Show resolved Hide resolved

angorayc and others added 4 commits March 5, 2025 10:33

Update x-pack/solutions/security/plugins/security_solution/public/plu…

5b268f8

…gin_contract.ts Co-authored-by: Sergi Massaneda <sergi.massaneda@gmail.com>

Update x-pack/solutions/security/plugins/security_solution/public/plu…

82a297d

…gin.tsx Co-authored-by: Sergi Massaneda <sergi.massaneda@gmail.com>

code review

7efa0f3

code review

666ef4f

angorayc marked this pull request as ready for review March 5, 2025 11:33

angorayc requested a review from a team as a code owner March 5, 2025 11:33

semd approved these changes Mar 5, 2025

View reviewed changes

angorayc enabled auto-merge (squash) March 5, 2025 11:50

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

93a2c5c

…-fix'

semd reviewed Mar 5, 2025

View reviewed changes

angorayc disabled auto-merge March 5, 2025 12:29

code review

5612a56

angorayc added 2 commits March 5, 2025 13:53

code review

9025334

code review

68d2c9e

angorayc added the release_note:skip Skip the PR/issue when compiling release notes label Mar 5, 2025

Merge branch 'main' into issue-212667

6a0d714

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SecuritySolution] Register AI Assistant management settings according to productFeatureKeys #213105

[SecuritySolution] Register AI Assistant management settings according to productFeatureKeys #213105

angorayc commented Mar 4, 2025 •

edited

Loading

angorayc Mar 4, 2025

angorayc Mar 4, 2025

angorayc Mar 4, 2025

semd Mar 4, 2025

semd Mar 4, 2025

angorayc Mar 4, 2025

kibanamachine commented Mar 4, 2025

elasticmachine commented Mar 5, 2025

semd left a comment

semd Mar 5, 2025 •

edited

Loading

angorayc Mar 5, 2025

angorayc Mar 5, 2025

elasticmachine commented Mar 5, 2025 •

edited

Loading

API count

References to deprecated APIs

	const isInProductFeatureKeys = productFeatureKeys && productFeatureKeys.length > 0 && productFeatureKeys.includes(ProductFeatureAssistantKey.assistant);
	const isInProductFeatureKeys = productFeatureKeys?.has(ProductFeatureAssistantKey.assistant);

[SecuritySolution] Register AI Assistant management settings according to productFeatureKeys #213105

Are you sure you want to change the base?

[SecuritySolution] Register AI Assistant management settings according to productFeatureKeys #213105

Conversation

angorayc commented Mar 4, 2025 • edited Loading

Summary

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kibanamachine commented Mar 4, 2025

elasticmachine commented Mar 5, 2025

semd left a comment

Choose a reason for hiding this comment

semd Mar 5, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented Mar 5, 2025 • edited Loading

💔 Build Failed

Failed CI Steps

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

References to deprecated APIs

History

angorayc commented Mar 4, 2025 •

edited

Loading

semd Mar 5, 2025 •

edited

Loading

elasticmachine commented Mar 5, 2025 •

edited

Loading