Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover Tabs] Add tab menu #213106

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[Discover Tabs] Add tab menu #213106

wants to merge 8 commits into from

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Mar 4, 2025 •
edited
Loading

Summary

This PR adds TabMenu component and implements the following actions:

  • Duplicate
  • Close other tabs
  • Close tabs to the right
Screenshot 2025-03-04 at 17 44 37

Testing

Two options are possible:

  1. start Storybook with yarn storybook unified_tabs and navigate to http://localhost:9001.
  2. start Kibana with yarn start --run-examples. Then navigate to the Unified Tabs example plugin http://localhost:5601/app/unifiedTabsExamples.

Checklist

@jughosta jughosta added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Project:OneDiscover Enrich Discover with contextual awareness labels Mar 4, 2025
@jughosta jughosta self-assigned this Mar 4, 2025
@jughosta
Copy link
Contributor Author

jughosta commented Mar 4, 2025

/ci

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

cc @jughosta

@jughosta jughosta marked this pull request as ready for review March 4, 2025 20:54
@jughosta jughosta requested a review from a team as a code owner March 4, 2025 20:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jughosta jughosta

Labels
backport:skip This commit does not require backporting Project:OneDiscover Enrich Discover with contextual awareness release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Discover Session][Tabs] Create TabMenu component
2 participants
@jughosta @elasticmachine