🌊 Streams: Improve integration tests #213115
Merged
+22
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
release_note:skip
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
|
simianhacker
approved these changes
Mar 4, 2025
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 4, 2025
I noticed that a couple integration tests were not actually validating whether the documents got routed the right way (the number and string tests). This PR fixes this by introducing a helper that can easily do the same check we had a couple of times in there. (cherry picked from commit ef0c364)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 4, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [🌊 Streams: Improve integration tests (#213115)](#213115) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Joe Reuter","email":"johannes.reuter@elastic.co"},"sourceCommit":{"committedDate":"2025-03-04T20:11:24Z","message":"🌊 Streams: Improve integration tests (#213115)\n\nI noticed that a couple integration tests were not actually validating\nwhether the documents got routed the right way (the number and string\ntests).\n\nThis PR fixes this by introducing a helper that can easily do the same\ncheck we had a couple of times in there.","sha":"ef0c364f11b485c29e4c9d065a93c2a4d12fb5eb","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","Feature:Streams","v9.1.0","v8.19.0"],"title":"🌊 Streams: Improve integration tests","number":213115,"url":"https://github.com/elastic/kibana/pull/213115","mergeCommit":{"message":"🌊 Streams: Improve integration tests (#213115)\n\nI noticed that a couple integration tests were not actually validating\nwhether the documents got routed the right way (the number and string\ntests).\n\nThis PR fixes this by introducing a helper that can easily do the same\ncheck we had a couple of times in there.","sha":"ef0c364f11b485c29e4c9d065a93c2a4d12fb5eb"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213115","number":213115,"mergeCommit":{"message":"🌊 Streams: Improve integration tests (#213115)\n\nI noticed that a couple integration tests were not actually validating\nwhether the documents got routed the right way (the number and string\ntests).\n\nThis PR fixes this by introducing a helper that can easily do the same\ncheck we had a couple of times in there.","sha":"ef0c364f11b485c29e4c9d065a93c2a4d12fb5eb"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that a couple integration tests were not actually validating whether the documents got routed the right way (the number and string tests).
This PR fixes this by introducing a helper that can easily do the same check we had a couple of times in there.