Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover][APM] Switch to document profile and split into spans/transactions #213116

Open
wants to merge 167 commits into
base: main
Choose a base branch
from
Open

[Discover][APM] Switch to document profile and split into spans/transactions #213116

wants to merge 167 commits into from
+1,023 −354

Conversation

iblancof
Copy link
Contributor

@iblancof iblancof commented Mar 4, 2025

Summary

Closes #211778 and #211871

This PR is a follow-up to issue #208693 and incorporates the suggestions from its associated PR #210612.

Note

Please note that most of the changes in this PR involve moving files, renaming data-test-subj attributes, updating imports, and not creating the files from scratch.

What's happening in this PR?

  • Transitioning from data source profile to document profile.
  • Splitting the traces document viewer into separate span and transaction viewers.
  • Enhancing the useTransaction hook to abort requests on component unmount.

As noted in the TODOs, a follow-up issue will focus on using for APM-configured indexes to enable the experience and retrieve the transaction.name for spans.

iblancof added 30 commits February 3, 2025 12:50
@iblancof
Add document viewer for traces-data-source-profile
334ff42
@iblancof
Add attribute IDs for span and transaction details
7055f3f
@iblancof
Create getAttributeConfiguration to get attribute content
44fcd51
@iblancof
Display raw attributes in overview tab
1d648a8
@iblancof
Add traces fields to field constants
cfde5cc
@iblancof
Add TraceDocumentOverview
b96f792
@iblancof
Add getTraceDocumentOverview utility function
2f059a9
@iblancof
Add UnifiedDocViewerTracesOverview
6ee5545
@iblancof
Refactor doc viewer to use UnifiedDocViewerTracesOverview and remove …
e0d7964 
…unused attribute IDs
@iblancof
Refactor getTraceDocumentOverview to simplify parameters and remove u…
f4d5869 
…nused field formatting
@iblancof
Add ServiceNameLink component for displaying service names with links
8433cc9
@iblancof
Remove "open in new tab" icon from ServiceNameLink component
3d9912a
@iblancof
Add TraceIdLink component for linking trace IDs to transaction details
c2eaff6
@iblancof
Refactor ServiceNameLink to use SERVICE_OVERVIEW_LOCATOR_ID and inclu…
518717b 
…de time range in navigation
@iblancof
Make 'service.name' and 'agent.name' fields required in TraceDocument…
b221117 
…Overview interface
@iblancof
Use ServiceNameLink in getAttributeConfiguration
edf4391
@iblancof
Use TraceIdLink in getAttributeConfiguration
f1fd397
@iblancof
Add TransactionNameLink component for linking transaction names to de…
4307aec 
…tails
@iblancof
Reorder spanAttributeIds to include SERVICE_NAME_FIELD after TRANSACT…
b1804bc 
…ION_NAME_FIELD
@iblancof
Add Timestamp component for displaying formatted timestamps in traces…
f486740 
… overview
@iblancof
Adjust text sizes in ServiceNameLink, TraceIdLink, and TransactionNam…
4849734 
…eLink components
@iblancof
Make timestamp prop required in Timestamp component
88bf2f7
@iblancof
Change '@timestamp' type from string to number in TraceDocumentOvervi…
4101ae6 
…ew and update Timestamp component props
@iblancof
Use lodash's castArray to format flattened fields
2f64847
@iblancof
Remove lodash's castArray usage for agentName in ServiceNameLink
e56e5af
@iblancof
Add duration and numeric formatters
511ad61
@iblancof
Add Duration component and integrate it into traces overview
25e2c75
@iblancof
Refactor TracesOverview component layout
12777e2
@iblancof
Add DependencyOverviewLocator and integrate into observability shared…
4a00a37 
… plugin
@iblancof
Add service.environment field to TraceDocumentOverview
8bf4121
@iblancof
Use UnifiedDocViewerObservabilityTracesSpanOverview in span doc viewer
ffd9085
@iblancof
Merge branch 'main' into 211778-discoverapm-switch-to-document-profil…
3c50060 
…e-and-enable-the-traces-doc-viewer-by-index-and-field
@iblancof
Add SpanSummary component and update SpanOverview to use it
e69da5a
@iblancof
Refactor field configuration for spans and transactions
98e6aff
@iblancof
Create UnifiedDocViewerObservabilityTracesTransactionOverview
64480b4
@iblancof
Remove UnifiedDocViewerTracesOverview usage
4942d8c
@iblancof
Fix wrong condition in TransactionSummary
3d373ca
@iblancof
Remove unused prop in TransactionOverview
98d0fb9
@iblancof
Delete unused TraceSummary
12034e5
@iblancof
Add unmount handling in useTransaction
3865814
@iblancof
Remove comments
b4839ac
@iblancof
Change unmount logic with abort signal
23486b3
@iblancof
Prepare span doc profile to recieve apm transaction index pattern
b04d96f
@iblancof
Add issue reference for TODOs
8fae4bc
@iblancof
Remove commented code
2c0a67c
@iblancof iblancof added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v9.1.0 labels Mar 4, 2025
@iblancof iblancof self-assigned this Mar 4, 2025
@iblancof iblancof requested review from a team as code owners March 4, 2025 14:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@iblancof iblancof linked an issue Mar 4, 2025 that may be closed by this pull request
[Discover][APM] Separate traces doc viewer into span and transaction doc viewers #211871
Open
@iblancof iblancof requested a review from a team March 4, 2025 15:01
@iblancof iblancof requested a review from davismcphee March 4, 2025 17:20
@iblancof
Merge branch 'main' into 211778-discoverapm-switch-to-document-profil…
90fe77c 
…e-and-enable-the-traces-doc-viewer-by-index-and-field
@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 4, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
discover 1179 1186 +7
unifiedDocViewer 277 284 +7
total +14

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
unifiedDocViewer 11 12 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 917.8KB 918.7KB +875.0B
unifiedDocViewer 202.8KB 204.7KB +1.9KB
total +2.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
discover 44.2KB 44.3KB +89.0B
unifiedDocViewer 11.8KB 12.1KB +258.0B
total +347.0B
Unknown metric groups

API count

id before after diff
unifiedDocViewer 17 19 +2

async chunk count

id before after diff
unifiedDocViewer 10 12 +2

ESLint disabled line counts

id before after diff
unifiedDocViewer 9 10 +1

Total ESLint disabled count

id before after diff
unifiedDocViewer 9 10 +1

History

cc @iblancof

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davismcphee davismcphee Awaiting requested review from davismcphee

At least 1 approving review is required to merge this pull request.

Assignees

@iblancof iblancof

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v9.1.0
Projects
None yet
Milestone
No milestone
3 participants
@iblancof @elasticmachine @kibanamachine