Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Security Solution][Detection Engine] adds bulkGetUserProfiles privilege to Security Feature (#211824) #213128

Merged
merged 1 commit into from
Mar 4, 2025
+65 −29
Merged

[8.x] [Security Solution][Detection Engine] adds bulkGetUserProfiles privilege to Security Feature (#211824) #213128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions x-pack/solutions/security/packages/features/src/security/v1_features/kibana_features.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ export const getSecurityBaseKibanaFeature = ({
'timeline_read',
'notes_write',
'notes_read',
'bulkGetUserProfiles',
],
savedObject: {
all: ['alert', ...savedObjects],
Expand Down Expand Up @@ -159,6 +160,7 @@ export const getSecurityBaseKibanaFeature = ({
'cloud-defend-read',
'timeline_read',
'notes_read',
'bulkGetUserProfiles',
],
savedObject: {
all: [],
Expand Down
10 changes: 9 additions & 1 deletion x-pack/solutions/security/packages/features/src/security/v2_features/kibana_features.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ export const getSecurityV2BaseKibanaFeature = ({
'cloud-security-posture-read',
'cloud-defend-all',
'cloud-defend-read',
'bulkGetUserProfiles',
],
savedObject: {
all: ['alert', ...savedObjects],
Expand All @@ -104,7 +105,14 @@ export const getSecurityV2BaseKibanaFeature = ({
read: {
app: [APP_ID, CLOUD_POSTURE_APP_ID, CLOUD_DEFEND_APP_ID, 'kibana'],
catalogue: [APP_ID],
api: [APP_ID, 'lists-read', 'rac', 'cloud-security-posture-read', 'cloud-defend-read'],
api: [
APP_ID,
'lists-read',
'rac',
'cloud-security-posture-read',
'cloud-defend-read',
'bulkGetUserProfiles',
],
savedObject: {
all: [],
read: [...savedObjects],
Expand Down
6 changes: 4 additions & 2 deletions x-pack/test/api_integration/apis/cases/bulk_get_user_profiles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,10 @@ import {
casesReadUser,
obsCasesAllUser,
obsCasesReadUser,
secAllCasesNoneUser,
secAllUser,
secReadCasesReadUser,
secAllCasesNoneUser,
secNoneUser,
} from './common/users';

export default ({ getService }: FtrProviderContext): void => {
Expand Down Expand Up @@ -67,6 +68,7 @@ export default ({ getService }: FtrProviderContext): void => {
{ user: secReadCasesReadUser },
{ user: casesReadUser },
{ user: obsCasesReadUser },
{ user: secAllCasesNoneUser },
]) {
it(`User ${
user.username
Expand All @@ -82,7 +84,7 @@ export default ({ getService }: FtrProviderContext): void => {
});
}

for (const { user } of [{ user: secAllCasesNoneUser }]) {
for (const { user } of [{ user: secNoneUser }]) {
it(`User ${
user.username
} with roles(s) ${user.roles.join()} cannot bulk get user profiles because they lack the bulkGetUserProfiles privilege`, async () => {
Expand Down
24 changes: 24 additions & 0 deletions x-pack/test/api_integration/apis/cases/common/roles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,6 +384,30 @@ export const secReadCasesNone: Role = {
},
};

export const secNone: Role = {
name: 'sec_none_role_api_int',
privileges: {
elasticsearch: {
indices: [
{
names: ['*'],
privileges: ['all'],
},
],
},
kibana: [
{
feature: {
siem: [],
actions: ['all'],
actionsSimulators: ['all'],
},
spaces: ['*'],
},
],
},
};

/**
* Roles for Cases in the stack
*/
Expand Down
8 changes: 8 additions & 0 deletions x-pack/test/api_integration/apis/cases/common/users.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ import {
secReadCasesAll,
secReadCasesNone,
secReadCasesRead,
secNone,
casesV2NoReopenWithCreateComment,
obsCasesV2NoReopenWithCreateComment,
secCasesV2NoReopenWithCreateComment,
Expand Down Expand Up @@ -132,6 +133,12 @@ export const secReadUser: User = {
roles: [secRead.name],
};

export const secNoneUser: User = {
username: 'sec_none_user_api_int',
password: 'password',
roles: [secNone.name],
};

export const secReadCasesNoneUser: User = {
username: 'sec_read_cases_none_user_api_int',
password: 'password',
Expand Down Expand Up @@ -297,6 +304,7 @@ export const users = [
secReadCasesAllUser,
secReadCasesReadUser,
secReadUser,
secNoneUser,
secReadCasesNoneUser,
casesOnlyDeleteUser,
casesOnlyReadDeleteUser,
Expand Down
44 changes: 18 additions & 26 deletions ...k/test_serverless/api_integration/test_suites/security/platform_security/authorization.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ export default function ({ getService }: FtrProviderContext) {
"api:cloud-security-posture-read",
"api:cloud-defend-all",
"api:cloud-defend-read",
"api:bulkGetUserProfiles",
"api:securitySolution-entity-analytics",
"api:securitySolution-threat-intelligence",
"api:securitySolution-showEndpointExceptions",
Expand Down Expand Up @@ -838,12 +839,11 @@ export default function ({ getService }: FtrProviderContext) {
"saved_object:search-session/delete",
"saved_object:search-session/bulk_delete",
"saved_object:search-session/share_to_space",
"ui:discover/show",
"ui:discover/save",
"ui:discover/saveQuery",
"ui:discover/createShortUrl",
"ui:discover/storeSearchSession",
"ui:discover/generateCsv",
"ui:discover_v2/show",
"ui:discover_v2/save",
"ui:discover_v2/createShortUrl",
"ui:discover_v2/storeSearchSession",
"ui:discover_v2/generateCsv",
"api:bulkGetUserProfiles",
"api:dashboardUsageStats",
"api:downloadCsv",
Expand Down Expand Up @@ -1079,6 +1079,7 @@ export default function ({ getService }: FtrProviderContext) {
"api:cloud-security-posture-read",
"api:cloud-defend-all",
"api:cloud-defend-read",
"api:bulkGetUserProfiles",
"api:securitySolution-entity-analytics",
"api:securitySolution-threat-intelligence",
"app:securitySolution",
Expand Down Expand Up @@ -1694,12 +1695,11 @@ export default function ({ getService }: FtrProviderContext) {
"saved_object:search-session/delete",
"saved_object:search-session/bulk_delete",
"saved_object:search-session/share_to_space",
"ui:discover/show",
"ui:discover/save",
"ui:discover/saveQuery",
"ui:discover/createShortUrl",
"ui:discover/storeSearchSession",
"ui:discover/generateCsv",
"ui:discover_v2/show",
"ui:discover_v2/save",
"ui:discover_v2/createShortUrl",
"ui:discover_v2/storeSearchSession",
"ui:discover_v2/generateCsv",
"api:bulkGetUserProfiles",
"api:dashboardUsageStats",
"api:downloadCsv",
Expand Down Expand Up @@ -1797,6 +1797,7 @@ export default function ({ getService }: FtrProviderContext) {
"api:rac",
"api:cloud-security-posture-read",
"api:cloud-defend-read",
"api:bulkGetUserProfiles",
"api:securitySolution-entity-analytics",
"api:securitySolution-threat-intelligence",
"app:securitySolution",
Expand Down Expand Up @@ -2070,13 +2071,8 @@ export default function ({ getService }: FtrProviderContext) {
"saved_object:search/find",
"saved_object:search/open_point_in_time",
"saved_object:search/close_point_in_time",
"saved_object:query/bulk_get",
"saved_object:query/get",
"saved_object:query/find",
"saved_object:query/open_point_in_time",
"saved_object:query/close_point_in_time",
"ui:discover/show",
"ui:discover/createShortUrl",
"ui:discover_v2/show",
"ui:discover_v2/createShortUrl",
"api:bulkGetUserProfiles",
"api:dashboardUsageStats",
"app:dashboards",
Expand Down Expand Up @@ -2167,6 +2163,7 @@ export default function ({ getService }: FtrProviderContext) {
"api:rac",
"api:cloud-security-posture-read",
"api:cloud-defend-read",
"api:bulkGetUserProfiles",
"api:securitySolution-entity-analytics",
"api:securitySolution-threat-intelligence",
"api:securitySolution-showEndpointExceptions",
Expand Down Expand Up @@ -2442,13 +2439,8 @@ export default function ({ getService }: FtrProviderContext) {
"saved_object:search/find",
"saved_object:search/open_point_in_time",
"saved_object:search/close_point_in_time",
"saved_object:query/bulk_get",
"saved_object:query/get",
"saved_object:query/find",
"saved_object:query/open_point_in_time",
"saved_object:query/close_point_in_time",
"ui:discover/show",
"ui:discover/createShortUrl",
"ui:discover_v2/show",
"ui:discover_v2/createShortUrl",
"api:bulkGetUserProfiles",
"api:dashboardUsageStats",
"app:dashboards",
Expand Down