[Obs AI Assistant] fix flaky test and add back test in settings #213196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neptunian
added
release_note:skip
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7979[✅] x-pack/test/observability_ai_assistant_functional/enterprise/config.ts: 25/25 tests passed. |
neptunian
added
backport:all-open
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7980[✅] x-pack/test/observability_ai_assistant_functional/enterprise/config.ts: 100/100 tests passed. |
|
Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant) |
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
sorenlouv
approved these changes
Mar 5, 2025
.../test/observability_ai_assistant_functional/tests/feature_controls/settings_security.spec.ts
Show resolved
Hide resolved
…e_controls/settings_security.spec.ts Co-authored-by: Søren Louv-Jansen <sorenlouv@gmail.com>
💔 Build Failed
Failed CI StepsHistory
|
sorenlouv
reviewed
Mar 5, 2025
| await searchConnectorIndexPatternInput.clearValue(); | ||
| await searchConnectorIndexPatternInput.type('test'); | ||
|
|
||
| await interceptRequest({ driver: driver.driver, pattern: '*kibana\\/settings*' }, (responseFactory) => { |
There was a problem hiding this comment.
You'll also need to update interceptRequest
There was a problem hiding this comment.
Thanks, I've reverted the change for now. I'm going to open up a separate PR for this. I'm going to remove our version and use the one added to the browser service, which date_usage plugin also uses. I'll update the other parts of our code to use it as well and implement the changes you suggested.
…s/feature_controls/settings_security.spec.ts" This reverts commit c629446.
|
Starting backport for target branches: 7.17, 8.16, 8.17, 8.18, 8.x, 9.0 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 5, 2025
…tic#213196) ## Summary Closes elastic#191707 Summarize your PR. If it involves visual changes include a screenshot or gif. - Fixes flaky test`allows updating of an advanced setting` by making sure to wait for page refresh - Adds back test to check for toast on error elastic#191531 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Søren Louv-Jansen <sorenlouv@gmail.com> (cherry picked from commit bccbb93)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 5, 2025
…tic#213196) ## Summary Closes elastic#191707 Summarize your PR. If it involves visual changes include a screenshot or gif. - Fixes flaky test`allows updating of an advanced setting` by making sure to wait for page refresh - Adds back test to check for toast on error elastic#191531 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Søren Louv-Jansen <sorenlouv@gmail.com> (cherry picked from commit bccbb93)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 5, 2025
#213196) (#213271) # Backport This will backport the following commits from `main` to `8.16`: - [[Obs AI Assistant] fix flaky test and add back test in settings (#213196)](#213196) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sandra G","email":"neptunian@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-05T16:46:02Z","message":"[Obs AI Assistant] fix flaky test and add back test in settings (#213196)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/191707\n\nSummarize your PR. If it involves visual changes include a screenshot or\ngif.\n\n- Fixes flaky test`allows updating of an advanced setting` by making\nsure to wait for page refresh\n- Adds back test to check for toast on error\nhttps://github.com//pull/191531\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Søren Louv-Jansen <sorenlouv@gmail.com>","sha":"bccbb933c0e2dea4c4d23c7174bbe0be638db252","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:all-open","Team:Obs AI Assistant","ci:project-deploy-observability","v9.1.0"],"title":"[Obs AI Assistant] fix flaky test and add back test in settings","number":213196,"url":"https://github.com/elastic/kibana/pull/213196","mergeCommit":{"message":"[Obs AI Assistant] fix flaky test and add back test in settings (#213196)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/191707\n\nSummarize your PR. If it involves visual changes include a screenshot or\ngif.\n\n- Fixes flaky test`allows updating of an advanced setting` by making\nsure to wait for page refresh\n- Adds back test to check for toast on error\nhttps://github.com//pull/191531\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Søren Louv-Jansen <sorenlouv@gmail.com>","sha":"bccbb933c0e2dea4c4d23c7174bbe0be638db252"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213196","number":213196,"mergeCommit":{"message":"[Obs AI Assistant] fix flaky test and add back test in settings (#213196)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/191707\n\nSummarize your PR. If it involves visual changes include a screenshot or\ngif.\n\n- Fixes flaky test`allows updating of an advanced setting` by making\nsure to wait for page refresh\n- Adds back test to check for toast on error\nhttps://github.com//pull/191531\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Søren Louv-Jansen <sorenlouv@gmail.com>","sha":"bccbb933c0e2dea4c4d23c7174bbe0be638db252"}}]}] BACKPORT--> Co-authored-by: Sandra G <neptunian@users.noreply.github.com>
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
neptunian
added a commit
to neptunian/kibana
that referenced
this pull request
Mar 6, 2025
…tic#213196) ## Summary Closes elastic#191707 Summarize your PR. If it involves visual changes include a screenshot or gif. - Fixes flaky test`allows updating of an advanced setting` by making sure to wait for page refresh - Adds back test to check for toast on error elastic#191531 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Søren Louv-Jansen <sorenlouv@gmail.com> (cherry picked from commit bccbb93) # Conflicts: # x-pack/test/observability_ai_assistant_functional/tests/feature_controls/settings_security.spec.ts
neptunian
added a commit
to neptunian/kibana
that referenced
this pull request
Mar 6, 2025
…tic#213196) ## Summary Closes elastic#191707 Summarize your PR. If it involves visual changes include a screenshot or gif. - Fixes flaky test`allows updating of an advanced setting` by making sure to wait for page refresh - Adds back test to check for toast on error elastic#191531 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Søren Louv-Jansen <sorenlouv@gmail.com> (cherry picked from commit bccbb93) # Conflicts: # x-pack/test/observability_ai_assistant_functional/tests/feature_controls/settings_security.spec.ts
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
neptunian
added a commit
to neptunian/kibana
that referenced
this pull request
Mar 6, 2025
…tic#213196) ## Summary Closes elastic#191707 Summarize your PR. If it involves visual changes include a screenshot or gif. - Fixes flaky test`allows updating of an advanced setting` by making sure to wait for page refresh - Adds back test to check for toast on error elastic#191531 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Søren Louv-Jansen <sorenlouv@gmail.com> (cherry picked from commit bccbb93) # Conflicts: # x-pack/test/observability_ai_assistant_functional/tests/feature_controls/settings_security.spec.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #191707
Summarize your PR. If it involves visual changes include a screenshot or gif.
allows updating of an advanced settingby making sure to wait for page refresh