[Discover][APM] Show event.outcome badge only on failure outcomes
#213268
+34
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bluefinger
added
release_note:skip
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
iblancof
approved these changes
Mar 6, 2025
There was a problem hiding this comment.
Thanks for taking care of this!
I’m just wondering if it might be worth proposing adding this visual rendering to the event.outcome column as well, and maybe considering other visually relevant columns like the status code.
Btw, I am not sure what happens if we don't add the version label, but it's missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes the
event.outcomebadge to no longer have an icon, instead appearing only when theevent.outcomevalue isfailure, and showing as adangercolored badge.Closes #213207
How to Test
Ensure the following is added to your kibana.dev.yml:
event.outcomeis eithersuccessorunknown. Only a red badge is shown for traces that haveevent.outcomeasfailure.