[UII] Remove scss usage #213281
Open
[UII] Remove scss usage #213281
+11
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jen-huang
added
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
nchaulet
reviewed
Mar 5, 2025
| export interface HeaderProps { | ||
| maxWidth?: number | string; | ||
| leftColumn?: JSX.Element; | ||
| rightColumn?: JSX.Element; | ||
| rightColumnGrow?: EuiFlexItemProps['grow']; | ||
| topContent?: JSX.Element; | ||
| tabs?: Array<Omit<EuiTabProps, 'name'> & { name?: JSX.Element | string }>; | ||
| tabsClassName?: string; | ||
| tabsCss?: string; |
There was a problem hiding this comment.
nit: will it be better to type this as an emotion interpolation as type here? and use emotion combination after?
There was a problem hiding this comment.
i tried a few ways of doing this including emotion interpolation here, but couldn't get it to work with the additional styles that we already add to EuiTabs 😔
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Module Count
Async chunks
Page load bundle
History
cc @jen-huang |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of https://github.com/elastic/kibana-team/issues/1417.
Removes Fleet's single usage of an
.scssfile to control page tab position for integration details page. Replaces it with a passed down css prop, UI looks the same:Checklist
release_note:*label is applied per the guidelines