[8.18] [Synthetics] Fix tls alert data !! (#212758) #213317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Summary This PR improves and fixes the TLS alert data handling in the Synthetics plugin. Key updates include: ### Code changes 1. **Request Body Updates**: - Added `agent.name`. - Changed optional chaining to direct property access for `ping.monitor.name`, `ping.monitor.id`, and `ping.observer.name`. - Added `ping.agent.name`. 2. **Cert Type Adjustments**: - Added fields: `monitorName`, `monitorId`, `monitorType`, `locationId`, `locationName`, `@timestamp`, `hostName`. 3. **Observer Codec**: - Ensured `name` and `geo.name` are required fields. 4. **Monitor Type and Ping Type**: - Added `name` to `MonitorType`. - Moved `@timestamp` to required fields in `PingType`. 7. **Message Utils**: - Adjusted `getCertSummary` and `getTLSAlertDocument` so that we can properly generate alert document (cherry picked from commit 80f4aab) # Conflicts: # x-pack/solutions/observability/plugins/synthetics/common/requests/get_certs_request_body.ts # x-pack/solutions/observability/plugins/synthetics/server/alert_rules/tls_rule/types.ts
botelastic
bot
added
the
Team:obs-ux-management
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
|
maryam-saeidi
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.18:Questions ?
Please refer to the Backport tool documentation