Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix conversation tests #213338

Merged
merged 1 commit into from
Mar 6, 2025
+95 −52
Merged

fix conversation tests #213338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
147 changes: 95 additions & 52 deletions ...n/deployment_agnostic/apis/observability/ai_assistant/conversations/conversations.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import {
type ConversationCreateRequest,
type ConversationUpdateRequest,
MessageRole,
Conversation,
} from '@kbn/observability-ai-assistant-plugin/common/types';
import type { SupertestReturnType } from '../../../../services/observability_ai_assistant_api';
import type { DeploymentAgnosticFtrProviderContext } from '../../../../ftr_provider_context';
Expand Down Expand Up @@ -408,8 +409,8 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon
});

describe('conversation duplication', () => {
let publicConversationId: string;
let privateConversationId: string;
let publicConversation: Conversation;
let privateConversation: Conversation;

before(async () => {
const publicCreateResp = await observabilityAIAssistantAPIClient.editor({
Expand All @@ -428,7 +429,7 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon
},
});
expect(publicCreateResp.status).to.be(200);
publicConversationId = publicCreateResp.body.conversation.id;
publicConversation = publicCreateResp.body;

const privateCreateResp = await observabilityAIAssistantAPIClient.editor({
endpoint: 'POST /internal/observability_ai_assistant/conversation',
Expand All @@ -446,88 +447,130 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon
},
});
expect(privateCreateResp.status).to.be(200);
privateConversationId = privateCreateResp.body.conversation.id;
privateConversation = privateCreateResp.body;
});

after(async () => {
for (const id of [publicConversationId, privateConversationId]) {
for (const conversation of [publicConversation, privateConversation]) {
const { status } = await observabilityAIAssistantAPIClient.editor({
endpoint: 'DELETE /internal/observability_ai_assistant/conversation/{conversationId}',
params: { path: { conversationId: id } },
params: { path: { conversationId: conversation.conversation.id } },
});
expect(status).to.be(200);
}
});

it('allows the owner to duplicate their own private conversation', async () => {
const duplicateResponse = await observabilityAIAssistantAPIClient.editor({
endpoint:
'POST /internal/observability_ai_assistant/conversation/{conversationId}/duplicate',
params: {
path: { conversationId: privateConversationId },
},
describe('allows the owner to duplicate their own private conversation', () => {
let duplicatedConversation: Conversation;
before(async () => {
const duplicateResponse = await observabilityAIAssistantAPIClient.editor({
endpoint:
'POST /internal/observability_ai_assistant/conversation/{conversationId}/duplicate',
params: {
path: { conversationId: privateConversation.conversation.id },
},
});
expect(duplicateResponse.status).to.be(200);

duplicatedConversation = duplicateResponse.body;
});
expect(duplicateResponse.status).to.be(200);

const duplicatedId = duplicateResponse.body.conversation.id;
expect(duplicatedId).not.to.eql(privateConversationId);
expect(duplicateResponse.body.user?.name).to.eql('elastic_editor');
after(async () => {
// cleanup
const { status } = await observabilityAIAssistantAPIClient.editor({
endpoint: 'DELETE /internal/observability_ai_assistant/conversation/{conversationId}',
params: { path: { conversationId: duplicatedConversation.conversation.id } },
});
expect(status).to.be(200);
});

const { status } = await observabilityAIAssistantAPIClient.editor({
endpoint: 'DELETE /internal/observability_ai_assistant/conversation/{conversationId}',
params: { path: { conversationId: duplicatedId } },
it('it should not be the same id', () => {
expect(duplicatedConversation.conversation.id).not.to.eql(
privateConversation.conversation.id
);
});

it('it should be the same user', () => {
expect(duplicatedConversation.user?.name).to.eql(publicConversation.user?.name);
});
expect(status).to.be(200);
});

it('allows the owner to duplicate their own public conversation', async () => {
const duplicateResponse = await observabilityAIAssistantAPIClient.editor({
endpoint:
'POST /internal/observability_ai_assistant/conversation/{conversationId}/duplicate',
params: {
path: { conversationId: publicConversationId },
},
describe('allows the owner to duplicate their own public conversation', () => {
let duplicatedConversation: Conversation;
before(async () => {
const duplicateResponse = await observabilityAIAssistantAPIClient.editor({
endpoint:
'POST /internal/observability_ai_assistant/conversation/{conversationId}/duplicate',
params: {
path: { conversationId: publicConversation.conversation.id },
},
});
expect(duplicateResponse.status).to.be(200);

duplicatedConversation = duplicateResponse.body;
});

after(async () => {
// cleanup
const { status } = await observabilityAIAssistantAPIClient.editor({
endpoint: 'DELETE /internal/observability_ai_assistant/conversation/{conversationId}',
params: { path: { conversationId: duplicatedConversation.conversation.id } },
});
expect(status).to.be(200);
});
expect(duplicateResponse.status).to.be(200);

const duplicatedId = duplicateResponse.body.conversation.id;
expect(duplicatedId).not.to.eql(publicConversationId);
expect(duplicateResponse.body.user?.name).to.eql('elastic_editor');
it('it should not be the same id', () => {
expect(duplicatedConversation.conversation.id).not.to.eql(
publicConversation.conversation.id
);
});

const { status } = await observabilityAIAssistantAPIClient.editor({
endpoint: 'DELETE /internal/observability_ai_assistant/conversation/{conversationId}',
params: { path: { conversationId: duplicatedId } },
it('it should be the same user', () => {
expect(duplicatedConversation.user?.name).to.eql(publicConversation.user?.name);
});
expect(status).to.be(200);
});

it('allows another user to duplicate a public conversation, making them the new owner', async () => {
const duplicateResponse = await observabilityAIAssistantAPIClient.admin({
endpoint:
'POST /internal/observability_ai_assistant/conversation/{conversationId}/duplicate',
params: {
path: { conversationId: publicConversationId },
},
describe('allows another user to duplicate a public conversation, making them the new owner', () => {
let duplicatedConversation: Conversation;
before(async () => {
const duplicateResponse = await observabilityAIAssistantAPIClient.admin({
endpoint:
'POST /internal/observability_ai_assistant/conversation/{conversationId}/duplicate',
params: {
path: { conversationId: publicConversation.conversation.id },
},
});
expect(duplicateResponse.status).to.be(200);

duplicatedConversation = duplicateResponse.body;
});
expect(duplicateResponse.status).to.be(200);

const duplicatedId = duplicateResponse.body.conversation.id;
expect(duplicatedId).not.to.eql(publicConversationId);
expect(duplicateResponse.body.user?.name).to.eql('elastic_admin');
after(async () => {
// cleanup
const { status } = await observabilityAIAssistantAPIClient.admin({
endpoint: 'DELETE /internal/observability_ai_assistant/conversation/{conversationId}',
params: { path: { conversationId: duplicatedConversation.conversation.id } },
});
expect(status).to.be(200);
});

const { status } = await observabilityAIAssistantAPIClient.admin({
endpoint: 'DELETE /internal/observability_ai_assistant/conversation/{conversationId}',
params: { path: { conversationId: duplicatedId } },
it('it should not be the same id', () => {
expect(duplicatedConversation.conversation.id).not.to.eql(
publicConversation.conversation.id
);
});

it('it should not be the same user', () => {
expect(duplicatedConversation.user?.name).to.not.eql(publicConversation.user?.name);
});
expect(status).to.be(200);
});

it('does not allow another user to duplicate a private conversation', async () => {
const duplicateResponse = await observabilityAIAssistantAPIClient.admin({
endpoint:
'POST /internal/observability_ai_assistant/conversation/{conversationId}/duplicate',
params: {
path: { conversationId: privateConversationId },
path: { conversationId: privateConversation.conversation.id },
},
});
expect(duplicateResponse.status).to.be(404);
Expand Down