Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [ML] Migrate anomaly explorer components from SCSS to Emotion (#212793) #213352

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

peteharverson
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…c#212793)

## Summary

Part of: elastic#140695
Migrates SCSS to emotion for several of the components used across the
Anomaly Explorer and Single Metric Viewer.

Removes the following SCSS files:

```
- x-pack/platform/plugins/shared/m/public/application/components/annotations/annotation_description_list/_index.scss
- x-pack/platform/plugins/shared/ml/public/application/components/entity_cell/_index.scss
- x-pack/platform/plugins/shared/ml/public/application/components/entity_cell/entity_cell.scss
- x-pack/platform/plugins/shared/ml/public/application/components/help_popover/help_popover.scss
- x-pack/platform/plugins/shared/ml/public/application/components/detector_description_list/_detector_description_list.scss
- x-pack/platform/plugins/shared/ml/public/application/components/rule_editor/components/detector_description_list/_index.scss
- x-pack/platform/plugins/shared/ml/public/application/explorer/explorer_charts/components/explorer_chart_label/_explorer_chart_label_badge.scss
- x-pack/platform/plugins/shared/ml/public/application/explorer/explorer_charts/components/explorer_chart_label/entity_filter/_entity_filter.scss
```

Components edited:
- Help popover

<img width="759" alt="Screenshot 2025-02-28 at 16 28 27"
src="https://github.com/user-attachments/assets/bc182d45-465b-406c-b122-921576ae8304"
/>

- Annotation description list:

<img width="952" alt="Screenshot 2025-02-28 at 16 29 16"
src="https://github.com/user-attachments/assets/71cae50c-41be-4299-8362-92567b73188e"
/>

- Rule editor detector description list:

<img width="674" alt="Screenshot 2025-02-28 at 16 30 02"
src="https://github.com/user-attachments/assets/f94a6878-3063-488f-85c5-2e6ee77bf1ad"
/>

- Anomalies table entity filters:

<img width="506" alt="Screenshot 2025-02-28 at 16 30 53"
src="https://github.com/user-attachments/assets/f074f175-9310-4a70-97b6-09be44af2ad2"
/>

- Explorer chart label badge and entity filters:

<img width="362" alt="Screenshot 2025-02-28 at 16 31 37"
src="https://github.com/user-attachments/assets/dd46ab81-e115-4e8c-ae00-864c83127c16"
/>

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit a1c520c)

# Conflicts:
#	x-pack/platform/plugins/shared/ml/public/application/components/influencers_list/influencers_list_styles.ts
@peteharverson peteharverson merged commit 6fd617c into elastic:8.x Mar 6, 2025
11 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ml 2457 2450 -7

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 5.4MB 5.4MB -4.2KB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants