[dashboard] fix map center change shows unsaved change after clicking reset #213445
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
|
/ci |
ThomThomson
approved these changes
Mar 6, 2025
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 7, 2025
… reset (elastic#213445) Closes elastic#213444 The problem is setting the view with the globe view may not set the view to the exact value. For example setting zoom to 1.74 may move the map to zoom 1.77. PR resolves this problem by adding a margin of error for comparing zoom differences. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit ea266bc)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 7, 2025
…icking reset (#213445) (#213585) # Backport This will backport the following commits from `main` to `8.x`: - [[dashboard] fix map center change shows unsaved change after clicking reset (#213445)](#213445) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2025-03-07T15:15:21Z","message":"[dashboard] fix map center change shows unsaved change after clicking reset (#213445)\n\nCloses https://github.com/elastic/kibana/issues/213444\n\nThe problem is setting the view with the globe view may not set the view\nto the exact value. For example setting zoom to 1.74 may move the map to\nzoom 1.77. PR resolves this problem by adding a margin of error for\ncomparing zoom differences.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"ea266bcd7e90cca036a82165a8c91ea81bc02c0e","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","Feature:Maps","backport:version","v9.1.0","v8.19.0"],"title":"[dashboard] fix map center change shows unsaved change after clicking reset","number":213445,"url":"https://github.com/elastic/kibana/pull/213445","mergeCommit":{"message":"[dashboard] fix map center change shows unsaved change after clicking reset (#213445)\n\nCloses https://github.com/elastic/kibana/issues/213444\n\nThe problem is setting the view with the globe view may not set the view\nto the exact value. For example setting zoom to 1.74 may move the map to\nzoom 1.77. PR resolves this problem by adding a margin of error for\ncomparing zoom differences.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"ea266bcd7e90cca036a82165a8c91ea81bc02c0e"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213445","number":213445,"mergeCommit":{"message":"[dashboard] fix map center change shows unsaved change after clicking reset (#213445)\n\nCloses https://github.com/elastic/kibana/issues/213444\n\nThe problem is setting the view with the globe view may not set the view\nto the exact value. For example setting zoom to 1.74 may move the map to\nzoom 1.77. PR resolves this problem by adding a margin of error for\ncomparing zoom differences.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"ea266bcd7e90cca036a82165a8c91ea81bc02c0e"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #213444
The problem is setting the view with the globe view may not set the view to the exact value. For example setting zoom to 1.74 may move the map to zoom 1.77. PR resolves this problem by adding a margin of error for comparing zoom differences.