Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configure project-id and project-number #4

Merged
merged 1 commit into from
Mar 8, 2025

Conversation

v1v
Copy link
Member

@v1v v1v commented Mar 7, 2025

Notifies elastic/elastic-agent#7232

What

Customise the project-id and project-number so we can support different GCPs.

Test

I'm testing this out in Buldkite, see build [it's not accessible for everyone but only elastic employees]

@v1v v1v marked this pull request as ready for review March 7, 2025 17:47
@v1v v1v requested review from Copilot, reakaleek and a team March 7, 2025 17:47

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR adds two new configuration properties for GCP integration: project-id and project-number.

  • Extends the plugin configuration file to include project-id (string) and project-number (number).
  • Updates the README documentation to reflect these new properties in the properties table.

Reviewed Changes

File Description
plugin.yml Adds new GCP properties with specified types.
README.md Updates property table to document the new props.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

README.md:10

  • [nitpick] The ordering of properties in the README table differs from the plugin configuration (project-number is listed before project-id, while plugin.yml defines project-id first). Consider reordering the README rows for consistency.
| `project-number` | The GCP project number.                                                                               | `false`  | `8560181848`            |
@v1v v1v self-assigned this Mar 7, 2025
@v1v v1v added the enhancement New feature or request label Mar 7, 2025
@v1v v1v merged commit eda0486 into main Mar 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants