Avoid downloading already existing chapters #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amananas
force-pushed
the
check_already_downloaded
branch
3 times, most recently
from
e89db64 to
d1dc366
Compare
Some chapters may have been previously downloaded, or a previous download session may have been interrupted. In any case, the user would rather not download again previously pulled chapters, and only download missing chapters. The download folder is now scanned for chapters that would be created, and detected chapters are skipped. The detection is based on file name, and the chapter number. A new run flag is introduced to force download anyways. Note: bundle download remains unchanged.
amananas
force-pushed
the
check_already_downloaded
branch
from
d1dc366 to
9091753
Compare
|
Good idea, but does not seem to be working for me 😕 I've tried with a random manga from mangadex, here's the command I've tried: go run . --language en https://mangadex.org/title/633d470a-4146-4dd3-b841-93dd648c23a5/the-academy-s-genius-swordsman 1-5Haven't had the time to dig into it and see why it's failing, what I've seen looks good. Also, remember to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some chapters may have been previously downloaded, or a previous download session may have been interrupted. In any case, the user would rather not download again previously pulled chapters, and only download missing chapters.
The download folder is now scanned for chapters that would be created, and detected chapters are skipped.
The detection is based on file name, and the chapter number.
A new run flag is introduced to force download anyways.
Note: bundle download remains unchanged.