Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(prebuild): remove make-dir dependency #600

Merged
merged 1 commit into from
Jul 10, 2024
Merged

chore(prebuild): remove make-dir dependency #600

merged 1 commit into from
Jul 10, 2024

Conversation

dsanders11
Copy link
Member

Replaces make-dir with built-in mkdir from Node.js, as recommended on https://github.com/sindresorhus/make-dir.

@dsanders11 dsanders11 requested a review from a team as a code owner July 10, 2024 19:20
@MarshallOfSound MarshallOfSound temporarily deployed to electronjsorg-new-pr-600 July 10, 2024 19:20 Inactive
erickzhao
erickzhao approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet

@erickzhao erickzhao merged commit 79cd8b1 into main Jul 10, 2024
4 checks passed
@erickzhao erickzhao deleted the chore/drop-make-dirs branch July 10, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzhao erickzhao erickzhao approved these changes

@erikian erikian erikian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dsanders11 @erickzhao @erikian @MarshallOfSound