Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api-structure-preview): adjust spacing styles #757

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

erickzhao
Copy link
Member

@erickzhao erickzhao commented Feb 13, 2025

@erickzhao erickzhao requested a review from a team as a code owner February 13, 2025 19:37
Copy link

cloudflare-workers-and-pages bot commented Feb 13, 2025

Deploying electron-website with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2ed2f5e
Status: ✅  Deploy successful!
Preview URL: https://d4cd7cee.electron-website.pages.dev
Branch Preview URL: https://fix-api-structure-preview-ad.electron-website.pages.dev

View logs

@nikwen
Copy link
Contributor

nikwen commented Feb 13, 2025

Wouldn't it make sense to make the i icon fully round?

This is what it looks like with the PR (macOS, Firefox):

image

@erickzhao
Copy link
Member Author

Wouldn't it make sense to make the i icon fully round?

Done! 2ed2f5e

Copy link
Contributor

@nikwen nikwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM! :)

@dsanders11 dsanders11 merged commit a33f436 into main Feb 13, 2025
4 checks passed
@dsanders11 dsanders11 deleted the fix/api-structure-preview-adjust-spacing-style branch February 13, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Adjust the i icon's margin/padding in crashReporter.getLastCrashReport().
3 participants