Clarify usage of alpha for scrim color.

element-hq · Feb 26, 2025 · 8c58a73 · 8c58a73
1 parent 74289bd
commit 8c58a73
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/compound/src/main/kotlin/io/element/android/compound/theme/MaterialColorSchemeDark.kt b/compound/src/main/kotlin/io/element/android/compound/theme/MaterialColorSchemeDark.kt
@@ -48,5 +48,5 @@ fun SemanticColors.toMaterialColorSchemeDark(): ColorScheme = darkColorScheme(
     outline = borderInteractivePrimary,
     outlineVariant = DarkColorTokens.colorAlphaGray400,
     // Note: for light it will be colorGray1400
-    scrim = DarkColorTokens.colorGray300.copy(alpha = 0.32f),
+    scrim = DarkColorTokens.colorGray300,
 )
diff --git a/compound/src/main/kotlin/io/element/android/compound/theme/MaterialColorSchemeLight.kt b/compound/src/main/kotlin/io/element/android/compound/theme/MaterialColorSchemeLight.kt
@@ -41,12 +41,12 @@ fun SemanticColors.toMaterialColorSchemeLight(): ColorScheme = lightColorScheme(
     surfaceTint = LightColorTokens.colorGray1000,
     inverseSurface = LightColorTokens.colorGray1300,
     inverseOnSurface = textOnSolidPrimary,
-    error = textCriticalPrimary, 
+    error = textCriticalPrimary,
     onError = textOnSolidPrimary,
     errorContainer = LightColorTokens.colorRed400,
     onErrorContainer = textCriticalPrimary,
     outline = borderInteractivePrimary,
     outlineVariant = LightColorTokens.colorAlphaGray400,
     // Note: for dark it will be colorGray300
-    scrim = LightColorTokens.colorGray1400.copy(alpha = 0.32f),
+    scrim = LightColorTokens.colorGray1400,
 )
diff --git a/compound/src/main/kotlin/io/element/android/compound/theme/MaterialTextPreview.kt b/compound/src/main/kotlin/io/element/android/compound/theme/MaterialTextPreview.kt
@@ -104,7 +104,10 @@ private fun MaterialPreview(
                     modifier = Modifier
                         .padding(12.dp)
                         .fillMaxWidth()
-                        .background(color = MaterialTheme.colorScheme.scrim)
+                        // the alpha applied to the scrim color does not seem to be mandatory.
+                        // The library ignores the alpha level provided and apply it's own.
+                        // For testing the color, manually set an alpha.
+                        .background(color = MaterialTheme.colorScheme.scrim.copy(alpha = 0.32f))
                         .padding(16.dp),
                     text = "${"Scrim"}\n${MaterialTheme.colorScheme.scrim.toHrf()}",
                     style = LocalTextStyle.current.copy(fontFamily = FontFamily.Monospace),