Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with compound-design-tokens #55

Merged
merged 3 commits into from
Jul 4, 2024
Merged

Sync with compound-design-tokens #55

merged 3 commits into from
Jul 4, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jul 4, 2024

Following element-hq/compound-design-tokens#85,

Remove the manually maintained file and rely only on what's coming from compound-design-tokens.

2 new theme added for high contrast colors.

Also some new icons that I will use after a release in EXA.

@bmarty bmarty requested a review from jmartinesp July 4, 2024 14:52
textPrimary = DarkColorTokens.colorGray1400,
textSecondary = DarkColorTokens.colorGray900,
textSuccessPrimary = DarkColorTokens.colorGreen900,
isLight = false,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked and this match what we had before, even better it fixes issue we had on textDecorative* 🤞

@bmarty bmarty added the Record-Screenshots Record new golden screenshots for the PR label Jul 4, 2024
@github-actions github-actions bot removed the Record-Screenshots Record new golden screenshots for the PR label Jul 4, 2024
@bmarty
Copy link
Member Author

bmarty commented Jul 4, 2024

@jmartinesp FTR I plan to do a release of Compound Android once this PR is merged.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bmarty bmarty merged commit ab12ae9 into main Jul 4, 2024
@bmarty bmarty deleted the bma/highContrast branch July 4, 2024 15:45
@bmarty bmarty mentioned this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants