Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync labels #328

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Sync labels #328

merged 1 commit into from
Oct 4, 2024

Conversation

langleyd
Copy link
Member

@langleyd langleyd commented Oct 2, 2024

What's in this PR?

  • Add sync labels script to sync with element-meta labels and merge with local labels
  • Add local labels file for compound specific labels

TODO

  • Somebody with access to the repo secrets to confirm ELEMENT_BOT_TOKEN exists.

@langleyd langleyd added the T-Task Tasks for the team like planning label Oct 2, 2024
@langleyd langleyd requested a review from a team as a code owner October 2, 2024 09:11
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what this is doing, but I trust it is correct 👍

@pixlwave pixlwave merged commit ca71352 into main Oct 4, 2024
2 checks passed
@pixlwave
Copy link
Member

pixlwave commented Oct 4, 2024

@langleyd Errr, ok it failed to run: https://github.com/element-hq/compound/actions/runs/11176351416/job/31069524078

Also, looking at that run, I wonder, do we actually want to sync labels with Compound? E.g. things like Rust: Expert don't particularly seem useful on this repo.

@langleyd
Copy link
Member Author

langleyd commented Oct 4, 2024

@pixlwave Looks like GH gives a 404 for insufficient privileges, so I'm guessing the ELEMENT_BOT_TOKEN could be invalid. I can have IT make sure it's up to date.

sync-labels merges labels with those on the element-meta repo and the local labels.yml file. It means we can maintain common labels across repos from a single place(element-meta), like the T- O- S- A- if we want to have common process/consistency. There are defo some in meta that need to be cleaned up(like old teams), but at least it can be done in one place.

Our plan with these two PR was to have the web ones sent to our triage board to be triaged in the same was as our other issues.

As you mention, it comes at the expense of some extraneous labels, but they can just be ignored? WDYT?

@pixlwave
Copy link
Member

pixlwave commented Oct 4, 2024

I can have IT make sure it's up to date.

👍

There are defo some in meta that need to be cleaned up(like old teams)

Right, got it. I guess I had assumed things like team and A- labels wouldn't be common, but makes sense to me, thanks for explaining.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants