Skip to content

Commit 0784a30

Browse files
committed
Update the strings on the join as guest screen
Hugh pointed out that the button labeled "Join call now" on this screen is misleading, because it does not join you to the call but rather send you to the lobby. Meanwhile, the designs call for this screen to use the words "Join as guest" and "Continue", so let's go with that.
1 parent e06aaf6 commit 0784a30

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

public/locales/en-GB/app.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@
9191
"layout_spotlight_label": "Spotlight",
9292
"lobby": {
9393
"ask_to_join": "Ask to join call",
94+
"join_as_guest": "Join as guest",
9495
"join_button": "Join call",
9596
"leave_button": "Back to recents",
9697
"waiting_for_invite": "Request sent"
@@ -128,8 +129,8 @@
128129
"register_confirm_password_label": "Confirm password",
129130
"register_heading": "Create your account",
130131
"return_home_button": "Return to home screen",
131-
"room_auth_view_eula_caption": "By clicking \"Join call now\", you agree to our <2>End User Licensing Agreement (EULA)</2>",
132-
"room_auth_view_join_button": "Join call now",
132+
"room_auth_view_continue_button": "Continue",
133+
"room_auth_view_eula_caption": "By clicking \"Continue\", you agree to our <2>End User Licensing Agreement (EULA)</2>",
133134
"screenshare_button_label": "Share screen",
134135
"settings": {
135136
"developer_settings_label": "Developer Settings",

src/room/RoomAuthView.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ export const RoomAuthView: FC = () => {
6464
<div className={styles.container}>
6565
<main className={styles.main}>
6666
<Heading size="xl" weight="semibold" className={styles.headline}>
67-
{t("lobby.join_button")}
67+
{t("lobby.join_as_guest")}
6868
</Heading>
6969
<Form className={styles.form} onSubmit={onSubmit}>
7070
<FieldRow>
@@ -98,7 +98,9 @@ export const RoomAuthView: FC = () => {
9898
disabled={loading}
9999
data-testid="joincall_joincall"
100100
>
101-
{loading ? t("common.loading") : t("room_auth_view_join_button")}
101+
{loading
102+
? t("common.loading")
103+
: t("room_auth_view_continue_button")}
102104
</Button>
103105
<div id={recaptchaId} />
104106
</Form>

0 commit comments

Comments
 (0)