Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Handling: gracefully handle missing livekit service url in config #3027

Merged
merged 11 commits into from
Feb 28, 2025

Conversation

BillCarsonFr
Copy link
Member

@BillCarsonFr BillCarsonFr commented Feb 26, 2025

Fixes #2971

How to test:

  • Update the local config.json in public/ folder and remove the livekit entry

Will generate this screen:

I tried to put a clear and not technical message, with a call to action to contact the server admin.
The error code should be enough for the admin to know what to do

I tried to do a more complete test that would setup a lobby with a video preview and trigger this error, but I would need more time to do so. Any direction could help.

Update

Following internal discussions did a quick refactoring to improve error structure (add a category to match this document), and also added more details on the RTC focus error: Include the domain and better title/description.

See this commit: 2ba803f

Now Error is:
image

Copy link
Member

@hughns hughns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One material thing to look at:

  • wording for ConnectionLostError

Otherwise just nits.

Copy link
Member

@hughns hughns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me 👍

As we are using existing strings for the "connection lost" description I think leave the wording as is.

@BillCarsonFr BillCarsonFr merged commit 66899f3 into livekit Feb 28, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show an error screen for when no MatrixRTC backend/SFU is exposed via .well-known and no fallback configured
3 participants